Skip to content
Snippets Groups Projects

Add macro DUNE_ASSERT_AND_RETURN

Merged Add macro DUNE_ASSERT_AND_RETURN
feature/assert-and-return into master
1 unresolved thread
Merged Carsten Gräser requested to merge feature/assert-and-return into master
1 unresolved thread

This is an alternative to !128 (closed).

In C++11 and with not fully C++14 compliant compilers constexpr functions can only have a return statement. This prevents the use of assert() inside of constexpr functions. This macro can be used as a workaround like this:

  constexpr auto foo(int a, int b, x)
  {
    return DUNE_ASSERT_AND_RETURN(a<b, x);
  }

For NDEBUG there is no penalty. Otherwise there are two options:

  • In a non-constexpr context an assert() will fail if the condition is not matched. The error message will be slightly different from a classic assertion.
  • In a constexpr context the assert() branch will be ignored if the is condition is matched. Otherwise this will lead to a compile error (like static_assert) because the branch using assert() is not constexpr.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
dune/common/assertandreturn.hh 0 → 100644
1 // -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
2 // vi: set et ts=4 sw=2 sts=2:
3 #ifndef DUNE_COMMON_ASSERTANDRETURN_HH
4 #define DUNE_COMMON_ASSERTANDRETURN_HH
5
6
7 // The macro DUNE_ASSERT_AND_RETURN can be used as expression in the return
8 // statement of a constexpr function to have assert() and constexpr at the
9 // same time. It first uses assert for the condition given by the first argument
10 // and then returns the value of the second argument.
11 #ifdef NDEBUG
12 #define DUNE_ASSERT_AND_RETURN(C,X) 0
  • Carsten Gräser Added 17 commits:

    Added 17 commits:

    Toggle commit list
  • Christian Engwer
    Christian Engwer @christi ·
    Owner

    Is there a particular reason why this isn't merged yet?

    I'll merge. If someone considers this a mistake, it can still be reverted.

  • Christian Engwer Mentioned in commit 1410d4a9

    Mentioned in commit 1410d4a9

  • Christian Engwer Status changed to merged

    Status changed to merged

    • Please register or sign in to reply