Add default include directories to headercheck targets
The headercheck utilites in our buildsystem create a set of libraries that are compile with make headercheck
. These libraries are created automatically and there are not many ways to influence the behavior. Currently, this feature does not work, if a module activates the target-based include directories, since the headercheck libraries are not linked against the module library. With this MR, we at least set the some include directories to these targets.
Merge request reports
Activity
added bug buildsystem labels
requested review from @santiago.ospina
assigned to @simon.praetorius
mentioned in merge request extensions/dune-alugrid!192 (merged)
- Resolved by Santiago Ospina De Los Ríos
I just read a bit of the headercheck code and some of the discussion in #212. This feature is indeed useful but this implementation has just too many assumptions and very little to no documentation. Adding
dune_default_include_directories
deepens these assumptions even further. In my opinion this should be re-implemented based on the FILE_SETS of a target. That would remove most of these assumptions. But since that's a CMake 2.23 feature we would have to wait a little bit for that. For now, I guess this is OK in order to advance in the CMake modernization (like needed in extensions/dune-alugrid!192 (merged))
mentioned in commit 6c054a7b
mentioned in issue #405