Feature/add cmake flags to dunecontrol

configure-opts no longer passes Bash-ish variables like CC=.. to CMake, instad -DCMAKE_C_COMPILER=.. must be used.

This fixes #93 (closed).

mentioned in issue #93 (closed)

I haven't tested this TBH, but as a lot of that bash code is probably horribly undertested, I think getting rid of it is a good idea.

Just from looking at the diff, it looks fine to me.

Looks good to me. I have two minor comments:

• I think the parameter (--configure-flags) should match the variable in the options file (CMAKE_FLAGS).
• A note in the change log would be appreciated.

OK, I finally managed to wrestle my git/bare/worktree setup and checkout the branch

There are a few inconsistencies I observed, where the semantics differ slightly from those of other commands:

• we usually read the options from the opts file
• we then overwrite the opts file options, if commandline options are provided
• we warn about overwriting
• we name the --*-opts the same way as we name the opts-file variable (see @martin.nolte s comment)

Thanks for the feedback.

• I'd rename the configure command in 2.7 to cmake. Together with renaming make to build and forwarding / deprecating the old commands.
• Christian is right, but I'd postpone these issues to 2.7 as well. Fixing these might introduce other bugs.
• We might back-port some of the bugfixes once they are mature enough.

added 1 commit

• 1d4344ac - [changelog] Add changes in dunecontrol's configure-opts

Compare with previous version

Huh, what's the status of this MR? Is this in 2.6 but not in master?

@gruenich Why do you think it's in 2.6? I checked and couldn't find the corresponding commits. I thought the suggest was to add this to master first and then possibly have it to 2.6.1. Wasn't that your suggestion?

added 46 commits

• 1d4344ac...89b9cbdf - 40 commits from branch master
• c4c88e18 - [cleanup] Remove some part of dunecontrol related to Autotools
• 38ef7384 - [clenaup] Remove now unused function module_la_libname
• b42d9cf9 - [cleanup] Change whitespace, reverse logic of if statement
• 737cfa95 - [cleanup] Whitespace and an improved comment
• 14b4acce - dunecontrol's configure-opts can be used for CMake flags
• e8b78576 - [changelog] Add changes in dunecontrol's configure-opts

Compare with previous version

Thanks Andreas, I had an typo and actually didn't switch to the releases/2.6 branch. You are right.

I am going to merge this into master. I think this is better suited for 2.6.0 as a semantically change with 2.6.1 should be avoided.

Later, I'll create new commands cmake and build for dunecontrol. We can back-port these for 2.6.1 without deprecating the current commands in 2.6.

Sorry, if I didn't express this in a clear manner.

enabled an automatic merge when the pipeline for e8b78576 succeeds

merged

mentioned in commit 17e449d1

mentioned in commit 5f2aa2f9

mentioned in merge request !424 (merged)