Skip to content
Snippets Groups Projects

[whitespace-hook] Check only those files we really intent to check.

Merged Jö Fahlke requested to merge fix/consistent-whitespace-checks into master
All threads resolved!
  • For markdown files, check them if they are in the toplevel directory or below doc/.
  • For the files that should only occur in the toplevel directory, make sure to only match them in the toplevel directory. This allows having them in an imported header only library in some subdirectory.
    • For files such as .cc or .hh that are matched by extension, there is no sane generic way to not check them when they are imported from somewhere else, so you'll still have to do something special, sorry.
  • For files that are matched by name, make sure that name matches the full basename of the file, not just a suffix.
  • Pass the regular expressions to perl in a safe way so they can contain arbitrary character without arcane quoting. This mostly applies to the path separator '/'.

Fixes: #106 (closed).

Edited by Jö Fahlke

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jö Fahlke added 1 commit

    added 1 commit

    • 60d5b4ca - [whitespace] Check all markdown files in the toplevel and below doc/.

    Compare with previous version

  • Jö Fahlke changed the description

    changed the description

  • Jö Fahlke resolved all discussions

    resolved all discussions

  • Jö Fahlke mentioned in commit 58affa8a

    mentioned in commit 58affa8a

  • merged

  • Please register or sign in to reply
    Loading