WIP: new cmake build system

Summary

• Separate cmake files instead of one big DuneMacros.cmake !957 (closed)
• Give all cmake functions the prefix dune_ (included in !957 (closed))
• Add argument to dune_project(<target>) to allow creation of a module library directly
• Remove global include_directories in favor of target_include_directories !944 (closed)
• Link tests created by dune_add_test automatically against module library
• Remove the cmake module include CMakeParseArguments !1008 (merged)
• Remove the cmake variable DUNE_DEFAULT_LIBS !1009 (merged)
• Simplify dune_library_add_sources by using target_sources !1010 (merged)
• Simplify enforcement of required c++ standard in cmake !862 (merged)
• Simplify functions from DuneModuleDependencies.cmake !1249 (merged)
• Set CMAKE_MODULE_PATH in <module>-config.cmake !1038 (closed)
• Move include(DuneModules) into dune-common-config.cmake
• Remove pkg-config support for finding dune packages (was not working before and not used. May be activated later again)
• Extract version of module dependencies from package file (instead of the dune.module file)
• Remove dune_enable_all_packages from default dune project

Superbuild

In order to build several modules in one run, prepare a CMakeLists.txt file in the root directory of all dune modules:

cmake_minimum_required(VERSION 3.13)
project(dune VERSION 2.9 LANGUAGES CXX)

set(dune_modules dune-common dune-geometry dune-localfunctions dune-uggrid dune-grid dune-istl)

set(CMAKE_PREFIX_PATH ${PROJECT_BINARY_DIR})
set(CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/dune-common/cmake/modules)
set(DUNE_DISABLE_SIMD_TESTS TRUE)

enable_testing()
foreach (mod ${dune_modules})
  add_subdirectory(${mod})
endforeach(mod)

include(FeatureSummary)
feature_summary(WHAT ALL)

added 1 commit

• 517e24cf - correct some small errors

Compare with previous version

added 1 commit

• bdc023f8 - prepare for super-builds

Compare with previous version

It seems unusual to have dashes in library names (libdune-common.so) (unless it is a dash before the version of the of the lib if it is encoded into the name). It will also break packages that do not use the DUNE CMake scripts, but their own. Maybe we should leave the library names as they are?

We also should think about how the aliases should be. the current Dune::dune-common looks a bit weired (could be my personal taste of course). How about Dune::Common?

added 10 commits

• ca87fea2 - initial commit of new cmake build system
• 74ec189b - reactivate headercheck
• fb46b3ae - rewritten the new build system based on recent developments in master
• 586150ab - update message function
• 5d811cce - test for metis and parmetis reset to master version
• 0ca592c6 - some bugfixes related to python
• cbed096f - add shared library option
• 2e7bdb5d - fix MPI_C problem and add AddLapackFlags
• 2e63ad03 - merge upstream changes
• 29e25a2e - remove DUNE_LIBS from default linking

Compare with previous version

Some parts of this MR can be extracted into separate MR:

• Deprecated DuneMPI.cmake in favour of AddMPIFlags.cmake + find_package(MPI in the DuneCommonMacros.cmake
• Add the Message.cmake backport and replace verbose message outputs in the Vc test files by message(TRACE ...). This macros exists in cmake 3.15 but not yet in cmake 3.13 (see !859 (merged))
• Cleanup DuneCommonMacros.cmake, by removing any package definitions and details about the found packages like the additional checks for LAPACK and move everything into the appropriate AddPackageFlags.cmake file (partially done)
• Relplace the target_link_libraries(TARGET LIBRARIES...) by target_link_libraries(TARGET SCOPE LIBRARIES...) wherever possible in the dune-common macros
• Add an optional-feature check macro to replace the old manual c++ feature detection file (see !862 (merged), !864 (closed))

mentioned in issue #211 (closed)

mentioned in merge request !862 (merged)

We made some progress. How should we proceed? Do you have a wish what to do next?

I have still no final idea, how to get rid of the repeated configure parts for dependencies.

added 212 commits

• 29e25a2e...1866e6cb - 196 commits from branch master
• 54473f2c - remove old deprecated type-traits that were renamed
• fffea4ca - Add Changelog entry
• 72070057 - Deprecated Dune::void_t in favor of std::void_t
• a4672058 - Replace CMAKE_SOURCE_DIR by PROJECT_SOURCE_DIR
• d81150de - Protect some custom targets created inside of macros
• 2c9dd604 - Cleanup cmake MPI module
• 535021f6 - Remove unnecessary comment
• cd2bab1c - Move find_package(PTScotch) to DuneCommonMacros
• 6f5f0b3c - Move definition of LAPACK_MANGLE and FC_FUNC to fmatrixev.cc
• c609bb2e - remove superbuild defines
• 92042c32 - remove CXX_MAX_STANDARD and CXX_MAX_SUPPORTED_STANDARD and deprecate dune_require_cxx_standard
• f20e0d19 - Remove global include_directories in favor of target_include_directories
• c5c61028 - Add module library
• 547cf2aa - Disable find package again
• 3e487e9f - cleanup Inkscape and MPI flags
• 1dcab931 - Design the new cmake build system

Compare with previous version

added 1 commit

• a7ae2a86 - reorganize main CMakeLists file

Compare with previous version

added 2 commits

• 62739e0b - Prefer std::void_t over Dune::void_t
• cc57ec18 - Merge branch 'feature/deprecated-void-t' into feature/new_build_system

Compare with previous version

I have collected all recent build-system related merge requests and made a forced push to update this branch to the current state. It can act as a testing branch for the new structure and shows the interplay between some merge requests.

added 17 commits

• b6a082b0 - 1 commit from branch master
• 6beadb94 - remove old deprecated type-traits that were renamed
• 75161630 - Add Changelog entry
• c42ad1be - Replace CMAKE_SOURCE_DIR by PROJECT_SOURCE_DIR
• 2b1fbd32 - Protect some custom targets created inside of macros
• 94088a36 - Cleanup cmake MPI module
• 8eea295b - Remove unnecessary comment
• ff3dad97 - Move find_package(PTScotch) to DuneCommonMacros
• c44ca2ca - Move definition of LAPACK_MANGLE and FC_FUNC to fmatrixev.cc
• a57ff7b3 - remove superbuild defines
• 14361cce - remove CXX_MAX_STANDARD and CXX_MAX_SUPPORTED_STANDARD and deprecate dune_require_cxx_standard
• c8af67cb - Remove global include_directories in favor of target_include_directories
• 9c5d305f - Add module library
• f4a10ac3 - Disable find package again
• bd25e4fc - cleanup Inkscape and MPI flags
• f128f85f - Design the new cmake build system
• 0632a9f6 - reorganize main CMakeLists file

Compare with previous version

added 1 commit

• c5edd909 - Add ARCHIV and LIBRARY DESTINATION

Compare with previous version

added 1 commit

• f3759fc6 - Globally include

Compare with previous version

added 1 commit

• 58fb056f - Make MPI a required dependency

Compare with previous version

added 1 commit

• 2d603f94 - Add cmake flags to tests

Compare with previous version