Skip to content
Snippets Groups Projects

[added to !932] Print message when compiling code just-in-time.

Closed [added to !932] Print message when compiling code just-in-time.
1 unresolved thread
Closed Samuel Burbulla requested to merge feature/verbose-jit into master
1 unresolved thread

Proposed fix for #215 (closed)

Edited by Andreas Dedner

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • This does solve most situations for users I guess. It misses the cases where code is recompiled because some headers in other parts of dune have changes but that will hardly be an issue for pure python users.

      I would suggest to have some verbosity flag that allows to turn these messages off?

    • I had a look how to get some verbosity in the case that recompilation is required but there seems to be no dry run option for cmake. One could use -- -n which is the dry run option for make and apparently also for ninja.

    • I see two remaining points:

      1. How do you imagine such a verbosity flag? Is it really necessary?
      2. I see no easy way to add verbosity for recompiling when headers change. I suppose that those who know that what's going on (because they changed some headers) do not really ask for this kind of verbosity?
    • I'll need to have a closer look at this - perhaps we can talk next week, e.g., after the meeting next Friday?

    • Please register or sign in to reply
  • Samuel Burbulla mentioned in merge request !909 (closed)

    mentioned in merge request !909 (closed)

  • Samuel Burbulla added 45 commits

    added 45 commits

    Compare with previous version

  • Shouldn't these message be printed to stderr so that I can separate them from the actual output of my program?

    An alternative would be to use the logger directly because that is an easy of switching these messages on/off.

    • Option 1: define a new level between info and warning (e.g. 15) which would be set as default and change the logger.info(msg) commands to logger.log(15, msg)
    • Option 2: have a look through the existing log messages and decide which ones should be kept as info and which should be downgraded to debug. So for example the output that a module is being loaded without recompilation would be moved to debug. After we have that the default log level would be info but if I don't want the output I would set it to warning by default (or warning is default and the user sets it to info).
  • added 1 commit

    • ed1b8c8b - Use logger and revise logger levels.

    Compare with previous version

  • I agree the logger is the better way to do this. But I think we should change the default behavior.

    What about my proposed changes?

    • Default level is INFO.
    • We use some simple default formatting "INFO: message". We could also add some DUNE prefix...
    • Most of current info calls are actually debug calls. The default should only give what a 'user' wants to see.

    I suppose important info information is:

    • Setting up dune-py (?)
    • Compiling - because you have to wait a long time and should be aware of that sth. is going on.
    • Not sure about initializing mpi?

    Everything else is either error or debug.

    Edited by Samuel Burbulla
  • added 1 commit

    • a83297f1 - Change format and set more to debug.

    Compare with previous version

  • Andreas Dedner changed title from Print message when compiling code just-in-time. to [added to !932] Print message when compiling code just-in-time.

    changed title from Print message when compiling code just-in-time. to [added to !932] Print message when compiling code just-in-time.

  • Andreas Dedner mentioned in merge request !932 (merged)

    mentioned in merge request !932 (merged)

Please register or sign in to reply
Loading