[added to !932] Print message when compiling code just-in-time.
1 unresolved thread
Proposed fix for #215 (closed)
Edited by Andreas Dedner
Merge request reports
Activity
I see two remaining points:
- How do you imagine such a verbosity flag? Is it really necessary?
- I see no easy way to add verbosity for recompiling when headers change. I suppose that those who know that what's going on (because they changed some headers) do not really ask for this kind of verbosity?
mentioned in merge request !909 (closed)
added 45 commits
-
d9f33d9d...7c5c1028 - 44 commits from branch
master
- f94206a5 - Print message when compiling code just-in-time.
-
d9f33d9d...7c5c1028 - 44 commits from branch
Shouldn't these message be printed to stderr so that I can separate them from the actual output of my program?
An alternative would be to use the logger directly because that is an easy of switching these messages on/off.
- Option 1: define a new level between info and warning (e.g. 15) which would be set as default and change the
logger.info(msg)
commands tologger.log(15, msg)
- Option 2: have a look through the existing log messages and decide which ones should be kept as
info
and which should be downgraded todebug
. So for example the output that a module is being loaded without recompilation would be moved todebug
. After we have that the default log level would be info but if I don't want the output I would set it towarning
by default (or warning is default and the user sets it to info).
- Option 1: define a new level between info and warning (e.g. 15) which would be set as default and change the
I agree the logger is the better way to do this. But I think we should change the default behavior.
What about my proposed changes?
- Default level is INFO.
- We use some simple default formatting "INFO: message". We could also add some DUNE prefix...
- Most of current info calls are actually debug calls. The default should only give what a 'user' wants to see.
I suppose important info information is:
- Setting up dune-py (?)
- Compiling - because you have to wait a long time and should be aware of that sth. is going on.
- Not sure about initializing mpi?
Everything else is either error or debug.
Edited by Samuel Burbullamentioned in merge request !932 (merged)
Merged in !932 (merged).
Please register or sign in to reply