[ug] Don't use dune-uggrid's symlinks

Use proper include paths instead

This breaks compatibility with UG 3.13, not dune-uggrid.

Requires staging/dune-uggrid!143 (merged)

changed milestone to %DUNE 2.7.0

@ansgar @oliver.sander This MR gives up compatibility to UG prior to dune-uggrid. This and the related change in dune-uggrid is a first step towards a layout that matches a Dune module. Further down the road we have to move the headers below dune/uggrid and simplify the folder structure. Many names are abbreviations and some folders contain only a single header. I think thats post 2.7.

If you really want consistency, shouldn't this be dune/uggrid/initug.h?

Sure, that's what I describe in this MR. But when moving headers around, we should also update and simplify the folder structure. I can come up with a proposal, but this is post-2.7.

Moving includes twice instead of just once is not that nice.

Where would include files be installed with your change? Currently it installs all files to ${includedir}/ug which is somewhat clean. Installing to several subdirectories would be a bit messy.

Uhm, right, dune-uggrid has its handwritten installation code. Then I propose to move the headers around according to my proposal in dune-uggrid#13 and also handle the installation Dune-style.

changed this line in version 3 of the diff

added 1 commit

• 6a52ec4d - [ug] Don't use dune-uggrid's symlinks

Compare with previous version

If you force me to move the stuff below dune/uggrid, I will do so. See dune-uggrid#13 for my proposal. Improvements welcome!

added 5 commits

• 6a52ec4d...e9df2002 - 4 commits from branch master
• d5f9d3a0 - [ug] Don't use dune-uggrid's symlinks

Compare with previous version

Does this look better to you?

mentioned in merge request staging/dune-uggrid!137 (closed)

Can you please rename the branch of staging/dune-uggrid!137 (closed) to match the name of the branch used here? That way, the CI system will test the two branches together.

added 18 commits

• d5f9d3a0...9d2bf027 - 17 commits from branch master
• 5c92e15f - [ug] Don't use dune-uggrid's symlinks

Compare with previous version

changed the description

@oliver.sander Can you have a look why the UG tests are crashing? On my computer I cannot reproduce the crashes. I also checked with AddressSanitizer and Valgrind, but I could not get any clue.

From looking at the CI logs: no idea :-(

I installed Debian 10.2, in sequential mode it works, in parallel mode Valgrind and GDB tell me, that in ugm.cc, line 421, the MYMG(theGrid) is an invalid read. Not sure how this could happen regarding my changes.

I tried this locally, and I do get a crash and the error message

ERROR in NewCommand: Unknown option 'h 500M'

That's because this merge request does not contain !345 (merged) yet. Can you please rebase?

added 6 commits

• 5c92e15f...f1fe83ed - 5 commits from branch master
• 0e22b22b - [ug] Don't use dune-uggrid's symlinks

Compare with previous version

Thanks for having a look. I want to bisect my commits this evening, I am running out of other ideas.

Are you really using feaure/dont-use-ug-symlinks? I rebased it a couple of days ago. Just to be sure, I just rebased it.

Thanks for rebasing. Now I get a real crash, and it's right at ugm.cc:421. So we are looking at the same thing. Let me have a look.