Stop using the HAVE_UG flag

It dates back from the days when UG3 was not a Dune module yet. Use HAVE_DUNE_UGGRID instead.

@christi , @andreas.dedner , other Python experts, can you please verify whether the Python-related change is correct?

Also, I am not sure whether removing the flag in doc/ is the right thing to do. Does anybody know?

added 1 commit

• 83e07dbe - Stop using the HAVE_UG flag

Compare with previous version

resolved all threads

This is exactly the problem... the HAVE_DUNE_UGGRIDS flag is not (yet) available, as it is only defined in dune_finalize, see dune-common!1074 (merged).

• this is already part of my MR !559 (merged)

So what do you want me to do here? Keep the HAVE_UG? Or remove the variable from that line altogether?

in CMake it should be dune-uggrid_FOUND no? HAVE_DUNE_UGGRID is the preprocessor variable. (Sometimes this is mixed for some variables. But for dune modules there is this clear separation I think.) But then I'm not sure what this like exactly does... I suspect it only passes the string and the value is then later extracted.

This specifies the meta data for python. The current implementation stores the set of variables to and makes them available in python under exactly the same name.

In order to have C++ and python consistent, we should imho use the preprocessor name here (which currently does not work, as discussed in the other MR.).

Perhaps we should keep a one more release?

We have had both variables for A Long Time. Unless we manage some sort of noticeable deprecation I don't see the point in keeping them much longer.

Are there objections to merging this? Otherwise I will merge on monday 20th Dec.

Are there objections to merging this? Otherwise I will merge on monday 20th Dec.

Go ahead

mentioned in commit 2c5f2db9

merged

mentioned in merge request staging/dune-uggrid!199 (merged)