Deprecate default implementation of jacobian() and jacobianInverse()

This deprecates the default implementation of the jacobian() and jacobianInverse() method and the corresponding typedefs Jacobian and JacobianInverse on the interface class Dune::Geometry where they have been introduced in !577 (merged). Hence grid geometry implementations should implement these members on their own and get a deprecation warning otherwise. After the next release this becomes a must. For any geometry in the core modules there's nothing left to do:

• All geometry implementations provided by dune-geometry have been adapted in dune-geometry!193 (merged).
• The utility class Dune::GeometryDefaultImplementation now implements the newly required members on top of the user-provided jacobianTransposed() and jacobianInverseTransposed(). This is safe, because the latter return a FieldMatrix.
• The only remaining implementation Dune::GeoGrid::Geometry is also adapted with this MR.

Other grid implementations need not to do anything if they only use the generic geometry implementations from dune-geometry or rely on Dune::GeometryDefaultImplementation. Otherwise they have to provide the four new members manually. The easiest (but maybe not the most efficient and elegant) way is to copy the default implementation deprecated with the present MR.

Notice that this is a follow-up MR to dune-geometry!193 (merged) and !577 (merged) and should this be merged afterwards.

dune/grid/common/geometry.hh

@@ -140,6 +140,17 @@ namespace Dune
 
     using JacobianDefault = decltype(transpose(std::declval<JacobianTransposed>()));
 
+
+    [[deprecated("Geometry implementatons are required to provide a jacobian(local) method. The default implementation is deprecated and will be removed after release 2.9")]]
+    auto deprecatedDefaultJacobian ( const LocalCoordinate& local ) const {
+      return transpose(jacobianTransposed(local));
+    }
+
+    [[deprecated("Geometry implementatons are required to provide a jacobianInverse(local) method. The default implementation is deprecated and will be removed after release 2.9")]]
+    auto deprecatedDefaultJacobianInverse ( const LocalCoordinate& local ) const {
+      return transpose(jacobianInverseTransposed(local));
+    }
+
   public:
 
     /**
@@ -322,7 +333,7 @@ namespace Dune
       if constexpr(Std::is_detected_v<JacobianOfImplementation, Implementation>)
         return impl().jacobian(local);
       else
-        return transpose(jacobianTransposed(local));
+        return deprecatedDefaultJacobian(local);
     }
 
     /** \brief Return inverse of Jacobian
@@ -351,7 +362,7 @@ namespace Dune
       if constexpr(Std::is_detected_v<JacobianInverseOfImplementation, Implementation>)
         return impl().jacobianInverse(local);
       else
-        return transpose(jacobianInverseTransposed(local));
+        return deprecatedDefaultJacobianInverse(local);
     }
 
     //===========================================================
@@ -403,6 +414,12 @@ namespace Dune
     //! type of jacobian transposed
     typedef FieldMatrix< ctype, mydim, cdim > JacobianTransposed;
 
+    //! type of jacobian inverse
+    typedef FieldMatrix< ctype, mydim, cdim > JacobianInverse;
+
+    //! type of jacobian
+    typedef FieldMatrix< ctype, cdim, mydim > Jacobian;
+
     //! return volume of the geometry
     Volume volume () const
     {
@@ -434,6 +451,18 @@ namespace Dune
       return asImp().global(refElement.position(0,0));
     }
 
+    //! Return the Jacobian
+    Jacobian jacobian ( const LocalCoordinate& local ) const
+    {
+      return asImp().jacobianTransposed(local).transposed();
+    }
+
+    //! Return inverse of Jacobian
+    JacobianInverse jacobianInverse ( const LocalCoordinate &local ) const
+    {
+      return asImp().jacobianInverseTransposed(local).transposed();
+    }
+
   private:
     //!  Barton-Nackman trick
     GeometryImp<mydim,cdim,GridImp>& asImp () {return static_cast<GeometryImp<mydim,cdim,GridImp>&>(*this);}
@@ -463,6 +492,12 @@ namespace Dune
     //! type of jacobian transposed
     typedef FieldMatrix< ctype, mydim, cdim > JacobianTransposed;
 
+    //! type of jacobian inverse
+    typedef FieldMatrix< ctype, mydim, cdim > JacobianInverse;
+
+    //! type of jacobian
+    typedef FieldMatrix< ctype, cdim, mydim > Jacobian;
+
     //! return the only coordinate
     FieldVector<ctype, cdim> global (const FieldVector<ctype, mydim>& local) const
     {
@@ -487,6 +522,18 @@ namespace Dune
       return asImp().corner(0);
     }
 
+    //! Return the Jacobian
+    Jacobian jacobian ( const LocalCoordinate& local ) const
+    {
+      return asImp().jacobianTransposed(local).transposed();
+    }
+
+    //! Return inverse of Jacobian
+    JacobianInverse jacobianInverse ( const LocalCoordinate &local ) const
+    {
+      return asImp().jacobianInverseTransposed(local).transposed();
+    }
+
   private:
     // Barton-Nackman trick
     GeometryImp<mydim,cdim,GridImp>& asImp () {return static_cast<GeometryImp<mydim,cdim,GridImp>&>(*this);}