Use unsigned char type for counting number of corners

The number of corners should never be higher than 8 (for hexahedra), thus 'unsigned char' is perfect to fix warnings here as it can safely be promoted to any other integer type.

changed title from Use unsigned short type for counting number of corners to Use unsigned char type for counting number of corners

Not that I have anything to say here, but:

Such code will be rather surprising to other developers. It might also have a performance impact. Have you benchmarked your change?

Have you benchmarked your change?

Not this one, but this code touched here is a sub set of !753 (merged) which improved up to 411% performance on intersection geometry operations. I am really skeptical one extra instruction will make any difference here.

Such code will be rather surprising to other developers.

Could you extend on this? I am really open to other alternatives to solve the signed and implicit conversion problem. unsigned char is the simplest one I could think of since it can be safely promoted to any other integer type.

mentioned in merge request !753 (merged)

Superseded by !764 (merged).

closed