Skip to content
Snippets Groups Projects

Split YaspGrid tests into more tests and introduce parallel testing

Merged Dominic Kempf requested to merge feature/yaspgrid-testing into master

The previous YaspGrid test was a single test which took ages to compile and run.

This branch remodels the Yasp testing suite to achieve the following:

  • Split the different parts into separate tests
  • Introduce a more sophisticated communication test
  • Test periodic grids
  • Do parallel testing through dune_add_test
  • Test with -Wall -Werror!!!
  • Have tests with and without deprecations!

Merge request reports

Pipeline #925 failed

Pipeline failed for 9518a788 on feature/yaspgrid-testing

Merged by avatar (Feb 20, 2025 6:04pm UTC)

Loading

Pipeline #926 failed

Pipeline failed for be04a447 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Milestone changed to %DUNE 2.5.0

  • @dominic What is the state of these changes? I'm at least interested in splitting test-yaspgrid into multiple smaller tests.

  • Ansgar Burchardt Status changed to closed

    Status changed to closed

  • Ansgar Burchardt Status changed to reopened

    Status changed to reopened

  • What's the status? I am very interested in getting the split into separate tests into the 2.5 release early. Currently, the huge yaspgrid test hinders testing. CI tests time out, and Debian build nodes run out of memory.

  • Perhaps Dominik can comment on the test coverage. Is something missing that was there before? If not new could cleanup the branch on tuesday?!

  • Reassigned to @smuething

  • We ( @oliver.sander and @christi ) rebased the commits onto master and will merge the current state after cleanup.

    The missing periodic test is not present in master, so we don't loose anything my merging. It can be added later in a separate merge-request.

  • Christian Engwer Added 284 commits:

    Added 284 commits:

    • 7e47c046...199b5472 - 269 commits from branch master
    • ef9e8a44 - [Tests] Added communication correctness test
    • 6af06b0a - [fixup] Install the new header comcorrectness.hh
    • 4f66cfb3 - [Tests] Split yaspgrid tests into multiple ones in a separate directory, reduced…
    • 35382400 - [Tests] Added parallel grid tests using MPI if available
    • 33d389a8 - [Tests] Include deprecation checks in yaspgrid tests
    • 0225feed - [Tests] Include refinement in yaspgrid tests
    • 4269b66e - [Tests] Run communication correctness test in yaspgrid tests
    • 9d0d170d - [Tests] Split yaspgrid backuprestore tests into multiple ones
    • a54e2397 - [Tests] Also create periodic yasp grids in the factory tests
    • 47887268 - [Tests] Removed some obsolete code
    • 5f8f053d - [CMake] Adapt the yaspgrid test subdirectory to dune_add_test
    • 60fc61e7 - Disable periodic testing for now
    • db80b978 - Mark the deprecation tests as COMPILE_ONLY
    • d3659aaf - specify timeout for parallel yaspgrid tests
    • 9518a788 - remove additional build parameters and the additional "-with(out)-deprecations" targets
  • Christian Engwer Unmarked this merge request as a Work In Progress

    Unmarked this merge request as a Work In Progress

  • Mentioned in commit be04a447

  • Christian Engwer Status changed to merged

    Status changed to merged

  • Christian Engwer Mentioned in issue #31

    Mentioned in issue #31

  • Please register or sign in to reply
    Loading