Skip to content
Snippets Groups Projects
  1. Aug 20, 2019
  2. Aug 12, 2019
  3. Aug 11, 2019
  4. Aug 09, 2019
  5. Jul 30, 2019
  6. Jul 18, 2019
  7. Jul 17, 2019
  8. Jul 11, 2019
  9. Jul 03, 2019
    • Robert K's avatar
      [!302] Make apply<forward> work with BlockPreconditioner and NonoverlappingBlockPreconditioner · 1baedfab
      Robert K authored
      Merge branch 'issue/apply_forward' into 'master'
      
      ref:core/dune-istl
      
      ### Summary
      
      Implement apply<forward> for NonoverlappingBlockPreconditioner and replace
      stored pointer with concrete type to allow the call to this non-virtual
      function.
      
      ### Details
      
      The method apply<forward>() is added for some preconditioners to allow to
      distinguish between forward and backward application. This is not part of the
      virtual interface in Preconditioner, so needs a concrete type to be called.
      The function was missing in the NonoverlappingBlockPreconditioner that wraps
      another preconditioner.
      
      For both block preconditioners, the function apply<forward>() is called on the
      abstract base class Preconditioner that does not have this method. So, instead
      of storing a pointer to the base class, store the passed preconditioner type
      directly that is available by template parameter.
      
      ### Backport
      
      In dune 2.6 the base-class problem was not a problem, since there always the
      template parameter type was stored. But the implementation in
      NonoverlappingBlockPreconditioner is missing there as well. This simply breaks
      generic code.
      
      Note, the problem was introduced in [!274]. This MR is related to issue [#69].
      
      See merge request [!302]
      
        [!274]: gitlab.dune-project.org/NoneNone/merge_requests/274
        [#69]: gitlab.dune-project.org/NoneNone/issues/69
        [!302]: gitlab.dune-project.org/core/dune-istl/merge_requests/302
      1baedfab
  10. Jun 27, 2019
  11. Jun 16, 2019
  12. Jun 15, 2019
  13. Jun 13, 2019
Loading