Skip to content
Snippets Groups Projects

Fix VariableBlockVector's CreateIterator

Merged Fix VariableBlockVector's CreateIterator
lasse.hinrichsen/dune-istl:bugfix/fix-vbv-create-iterator into master
All threads resolved!
Merged Lasse Hinrichsen-Bischoff requested to merge lasse.hinrichsen/dune-istl:bugfix/fix-vbv-create-iterator into master
All threads resolved!

When the postfix increment operator is used, block sizes will not be set properly, see #56 (closed).

This implementation places the allocation into the destructor of the iterator.

It does not need additional structures.

This MR also fixes the test for interoperability with STL algorithms: As the CreateIterator is only an output iterator, use std::fill_n() instead of std::fill().

See !249 (closed). Fixes #56 (closed).

Edited by Steffen Müthing

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Steffen Müthing added 2 commits

    added 2 commits

    • 151c3e10 - Tunnel size access of the CreateIterator through a proxy to work around…
    • 91ac8314 - Revert changes to block vector window

    Compare with previous version

  • Steffen Müthing resolved all discussions

    resolved all discussions

  • Steffen Müthing added 1 commit

    added 1 commit

    • 142e570a - Revert changes to block vector window

    Compare with previous version

  • Steffen Müthing
    Steffen Müthing @smuething ·
    Owner

    And yes, the pipeline failure is down to #51 (closed).

  • Steffen Müthing mentioned in merge request !249 (closed)

    mentioned in merge request !249 (closed)

  • Steffen Müthing changed the description

    changed the description

  • Steffen Müthing added backport bug labels

    added backport bug labels

  • Steffen Müthing changed milestone to %DUNE 2.7.0

    changed milestone to %DUNE 2.7.0

  • Steffen Müthing assigned to @smuething

    assigned to @smuething

  • Steffen Müthing mentioned in commit a7db0489

    mentioned in commit a7db0489

  • Steffen Müthing merged

    merged

  • Steffen Müthing mentioned in commit 8f967210

    mentioned in commit 8f967210

  • Steffen Müthing mentioned in merge request !256 (closed)

    mentioned in merge request !256 (closed)

  • Steffen Müthing mentioned in commit 30e46e20

    mentioned in commit 30e46e20

    • Please register or sign in to reply