Remove class VintageBasisGridFunction

The class VintageBasisGridFunction has been removed, because it relied on the old dune-fufem interface for function space bases.

Use Dune::Functions::DiscreteGlobalBasisFunction instead.

@carsten.graeser , okay?

In the long run yes. But I'd first like to get rid of the old VirtualFunction interface. During this transition this class may still be helpful.

E.g. there are places where old assemblers with old bases are tested using BasisGridFunction. Here we can replace the latter by Vintage... to get rid of the VirtualFunction deprecation as an intermediate step.

But I can do the same with DiscreteGlobalBasisFunction<DuneFunctionsBasis> can I not?

Almost. But the interface for customizing the local evaluation is different. Furthermore Vintage... supports constraints.

I furthermore intended to first (A) remove the VirtualFunction interface and then (B) the old bases. Following this transition path we should rather remove BasisGridFunction before VintageBasisGridFunction, because the former is even more vintage. Although VintageBasisGridFunction is currently not used elsewhere in dune-fufem, it's the straight forward replacement for VintageVintageBasisGridFunction during step A (using the convention that VintageVintage cancels out).

Cf. !146 (merged) which replaces BasisGridFunction by VintageBasisGridFunction in at least one place, because it's used with a constrained (conforming) basis.

added 26 commits

• f5a95f40...0d4253a6 - 25 commits from branch master
• bd0b7ed4 - Remove class VintageBasisGridFunction

Compare with previous version

mentioned in merge request !263 (merged)

This was superseded by !263 (merged).

closed