Arne Morten Kvarving authored 8 years ago and Christoph Grüninger committed 8 years ago

API for solver routine changed. Since there is no versioning
in SuperLU we have to do a probe to detect the new library.

[cmake][bugfix] Fix the testsuite for sequential builds

Some tests assume MPI being present, although they are not executed
in parallel. This information got lost in the transition to dune_add_test
and is restored with this patch. Thanks to @markus.blatt for noticing.

This fixes #13 

See merge request !38

Abort CGSolver when the defect is invalid

The first commit introduces the exception `SolverAbort`, derived from `ISTLError`.

The second commit makes `CGSolver` abort by throwing `SolverAbort` when the defect becomes invalid (infinite or NaN).  The check is done in every iteration before the convergence check.

These two commits fix #12.

The third and fourth commit make `BiCGStab` and `GMRes` throw `SolverAbort` when they detect a breakdown.  `SolverAbort` seemed more specific when the `ISTLError` they were throwing before.

The fifth commit documents when `SolverAbort` is thrown at the moment.

The sixth commit adds a unit tests that tries to trigger `SolverAbort` and makes sure that it is actually thrown.  It does this for the NaN-check in `CGSolver` and for the "abs(h) < EPSILON"-check in `BiCGSTABSolver` -- there a more conditions in `BiCGSTABSolver` and `RestartedGMResSolver` that throw, but I don't know how to trigger them.



See merge request !36

Here we try to solve A*x=b for x, with
```
      / 1  1 \       / 1 \
  A = |      |,  b = |   |,
      \ 1  1 /       \ 2 /
```
which has no solution.  In the CGSolver, the this leads to a NaN defect after
46 iterations.  In BiCGSTABSolver this leads to "abs(h) < EPSILON" after 1.5
iterations.

BiCGSTABSolver and RestartedGMResSolver also throw SolverAbort when they
detect "breakdown", checking for that is left as a todo.

Don't throw std::exception but print message and exit

Fixes core/dune-common#23

See merge request !39

Fixes dune-common#23

Some tests assume MPI being present, although they are not executed
in parallel. This information got lost in the transition to dune_add_test
and is restored with this patch. Thanks to @markus.blatt for noticing.

[cleanup] fix some typos in documentation strings and error messages



See merge request !37

[bugfix] Fixes access to non-existing parallel info in FastAMG::recalculateHierachy

recalculateHierarchy() assumed that there is information avaiable
that is only there in parallel runs. This failed miserably.

This commit fixes this be implementing dummy versions for
redistributing matrices in  a sequential run and does not
query any parallel stuff any more

This closes #11.

See merge request !34

Merge branch 'feature/make-matrixredisttest-compile-again' into 'feature/fix-fastamg-buildhierarchy'

[matrixredistribute.hh] Fix missing #include <dune/istl/paamg/pinfo.hh>.

The previous commit made fastamg compile, but broke compilation of
matrixredisttest for me.  This makes matrixredisttest compile again.

See merge request !35

Document that `BiCGSTABSolver` and `RestartedGMResSolver` can throw
`SolverAbort` when they detect a breakdown.

The previous commit made fastamg compile, but broke compilation of
matrixredisttest for me.  This makes matrixredisttest compile again.

SolverAbort is derived from ISTLError, so any existing catch-clause should
still apply.

SolverAbort is derived from ISTLError, so any existing catch-clause should
still apply.

recalculateHierarchy() assumed that there is information avaiable
that is only there in parallel runs. This failed miserably.

This commit fixes this be implementing dummy versions for
redistributing matrices in  a sequential run and does not
query any parallel stuff any more

This closes #11.

[amg][bugfix] Fix dirichlet processing in FastAMG

The comment and surroundig code indicate that FastAMG should
solve during pre() for dirichlet entries. This is determined
by checking if a row does contain a diagonal entry while
all other entries are zero.

The check for this was buggy because hasDiagonal was always false.
This merge commits sets it to true if a diagonal entry is found and nonzero.

See merge request !32

This allows other code to access field_type and real_type for a MultiTypeBlockVector
using the FieldTraits class.  Caveat: in principle, individual entries of a
MultiTypeBlockVector could use different field_types.  The implementation always
returns the first one.

Adding a new template perameter before the existing ones is
a non-compatible interface change, because code that explicitly
instantiates the template will fail to compile afterwards.

Putting the new template parameter to the end fixes the issue

I missed a few occurrences of 'nblocks' when renaming that to 'rows_',
because it was hidden behind the DUNE_ISTL_WITH_CHECKING macro.

[amg] Silence FastAMG if debugLevel=0

There was an unconditional debug output in FastAMG.
With this commit this is will only be printed if
debugLevel>0.

See merge request !31

Carsten Gräser authored 9 years ago and Christoph Grüninger committed 9 years ago

There was an unconditional debug output in FastAMG.
With this commit this is will only be printed if
debugLevel>0.

This additional check currently fails.

[fix] Remove coumns_, probably a copy-n-paste artifact



See merge request !33

The comment and surroundig code indicate that FastAMG should
solve during pre() for dirichlet entries. This is determined
by checking if a row does contain a diagonal entry while
all other entries are zero.

The check for this was buggy because hasDiagonal was always false.
Now it's set to true if a diagonal entry is found and nonzero.

The dune-common module now contains short-cuts for static indices of type
integral_constant<size_t,...>, and we should try to standardize on those.

In particular, this means that static indices are integral_constant<std::size_t,...> now,
rather than integral_constant<int,...>.  We decided to standardize on std::size_t.

This array was a left-over from the VariableBlockVector class.  In short,
it stores the length of each matrix row.  Of course that is redundant,
because all rows in a dense matrix have the same length.

This patch makes the class allocate less memory, and use the known row
size to compute the offsets into the data array.  In principle, the code
becomes faster by this, but I am not convinced that the effect will be
measurable.

Still, even without measurable speedup: this patch is an improvement,
because it makes the code simpler.

doc: fix typo: writee -> write



See merge request !30

[bugfix] add missing header

Header `dune/common/exceptions.hh` is not included but exceptions are used.

See merge request !29

Matrix loadbalance to more

There was a problem when having the global matrix and using load balance
to distribute it. This is fixed by the MR.

These changes should be cherrypicked to the release, too.

See merge request !28

One of the use cases for load balancing a matrix is reading it globally
on one process and then calling the load balancer to distribute it among
the processes. Unfortunately this did not work due to a bug that prevented
the correct remapping of the domain numbers from the load balancers. This
lead to negative rank numbers.

With this commit we use yet unassigned process numbers for domains that
are not yet mapped (due to having no dofs before the load balancing).

[cmake][bugfix] Correct handling of the EXCLUDE_FROM_ALL property:

The signature of `dune_add_test`, that takes the `TARGET` from the user
produced excluded targets if added in a directory that has the directory
property `EXCLUDE_FROM_ALL` set. The correct solution IMO is to not use
that property on test subdirectories anymore (it is a relic from the old
testing magic), because we rely on `dune_add_test` to handle exclusion.

See core/dune-common#21 for details.

See merge request !27