Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • D dune-logging
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • staging
  • dune-logging
  • Merge requests
  • !6

Make logging functions on Logger const

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Steffen Müthing requested to merge feature/make-logging-functions-const into master Jul 01, 2019
  • Overview 0
  • Commits 2
  • Pipelines 2
  • Changes 2

Santiago had the valid comment that it would be better to have the logging methods non-const, as otherwise you would have to make logger member variables mutable to be able to log in const member functions. It's actually consistent as well, since the logging calls do not modify the internal state of the logger itself.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/make-logging-functions-const