Christoph Grüninger authored 1 year ago and Oliver Sander committed 1 year ago

Missing variable found as a result of reduced variable scope

Christoph Grüninger authored 1 year ago and Oliver Sander committed 1 year ago

Cppcheck found this (duplicateConditionalAssign)

Found by cppcheck

Found by cppcheck

It is not sure that g is set, now it will be at least NULL.
Found by cppcheck

Reduces risk of misuse or typos, improve readability.
Found by cppcheck

Fix a couple of cppcheck findings

See merge request !227

This prevents shadowing of i and j
Found by cppcheck

Move dereference after NULL check
Found by cppcheck

Found by cppcheck

Rename i to rule to use proper variable in debug output.
This was found by cppcheck

Instead of printing the total of inspected elements, the code
just pointed one element after the array.
Add proper code to sum up the number of inspected elements.
This was found by cppcheck

After the for loop, i is beyond the last element.
Founc by cppcheck

Saves a memory allocation.
Found by cppcheck

[cmake] Require CMake 3.16 or newer

See merge request !226

Simplifications and removal of unused code

See merge request !225

They are not actually used.

Instead, store them directly in the 'domain' class.

This simplifies the structure of the code.  It also saves a bit of
memory, because the meta data for the environment heap is not
needed anymore.

Instead, store it directly in the 'domain' data structure.
This simplifies setting up the domain boundary a little bit.
Also, it saves a bit of memory, because environment items
store some extra information.  In particular, they store
a name in an array of fixed size char[128].  In the case
of linear_segment objects, however, these names are never
actually used.

Subdomains are not used anymore.

These numbers are not used anymore.

They are not shorter or more readable than 0, 1, 2.

Fix 'thePatch may be uninitialized' warning

See merge request !224

Mainly by reducing its scope.  Also, it appeared in the signature
of the CreateLine method without being needed there.

Adapt dune_add_library by specifying EXPORT_NAME

See merge request !221

Use FieldVector for point coordinates

See merge request !220

Santiago Ospina De Los Ríos authored 1 year ago and Santiago Ospina De Los Ríos committed 1 year ago

* Add EXPORT_NAME property to add_dune_library
* Link explicitly against Dune::Common

Rather than in a C array.  This allows the compiler to check better
whether we are using the position arrays correctly.

This patch is a first step towards replacing C arrays that represent
points by FieldVector.  The motivation is to have the compiler
enforce a bit more type safety.

This patch uses casts in a few places to go from DOUBLE[] to
FieldVector.  They will disappear in later commits when more
arrays are replaced by FieldVector.