Skip to content
Snippets Groups Projects
  1. Oct 24, 2016
    • Ansgar Burchardt's avatar
      Merge branch 'feature/document-codim-parameter' into 'master' · 1382293c
      Ansgar Burchardt authored
      document sementics of codim parameter for IndexSet::subIndex
      
      If an entity of codimension cc > 0 is passed into IndexSet::subIndex, what
      is the semantics of the 'codim' parameter? In DUNE, codimensions are always
      with respect to the grid dimension (see method subEntity of reference element).
      
      This patch clearly states that codim is to be understood with respect to the
      grid dimension.
      
      See merge request !97
      1382293c
    • Ansgar Burchardt's avatar
      Merge branch 'feature/fix-headercheck' into 'master' · 88bfaa67
      Ansgar Burchardt authored
      Fix includes etc. to make headercheck pass
      
      This should solve #35 .
      
      See merge request !108
      88bfaa67
    • Martin Nolte's avatar
      [doc] document sementics of codim parameter for IndexSet::subIndex · f42aa84b
      Martin Nolte authored
      If an entity of codimension cc > 0 is passed into IndexSet::subIndex, what
      is the semantics of the 'codim' parameter? In DUNE, codimensions are always
      with respect to the grid dimension (see method subEntity of reference element).
      
      This patch clearly states that codim is to be understood with respect to the
      grid dimension.
      f42aa84b
  2. Oct 21, 2016
  3. Oct 20, 2016
    • Carsten Gräser's avatar
      Merge branch 'feature/fix-uggrid-subindex' into 'master' · e2946e00
      Carsten Gräser authored
      Fix subIndex method for UGGrid
      
      When using Hygrid::ifElse always keep in mind that some types in
      the functions given as "if" and "else" branch are fixed, such that
      compilation may fail altough the template is not instanciated.
      
      To avoid this, those functions have one templated parameter which
      is instanciated with the identity for the selected branch. Passing
      objects through this branch will delay resolution of their type
      until instantiation which does only happen for the selected branch.
      
      By passing the entity through `id` we use this to make subIndex
      compile for clang. It seems that gcc is less picky here.
      
      See merge request !101
      e2946e00
  4. Oct 19, 2016
  5. Oct 18, 2016
  6. Oct 14, 2016
    • Oliver Sander's avatar
      Merge branch 'feature/static-gridview-check-for-codims-only-inline' into 'master' · 199b5472
      Oliver Sander authored
      [test] add static check for higher codimension information on grid views
      
      Until now, the static part of the grid check only check on codim 0 structures,
      e.g., on the index set. This patch also performs these checks on higher
      codimensions.
      
      For the IndexSet::subIndex method, it will only check whether the method
      compiles. If codim > 0, it will silently ignore a Dune::NotImplemented
      exception, so that grids are not forced to implement the method; it simply has
      to compile.
      
      Note: This check is able to detect the error fix in !86.
      
      This merge request is basically !89 , but with Martin's initial implementation removed.
      As it only lived to be completely replaced 24h later, I didn't see the point in keeping
      it in the history.
      
      See merge request !96
      199b5472
    • Oliver Sander's avatar
      Merge branch 'feature/implement-uggrid-subindex-for-all-dimensions-2nd-attempt' into 'master' · c3b6aed2
      Oliver Sander authored
      Implement the subIndex method for entities of all dimensions
      
      Previously, it was available only for elements.
      
      The following question appears: what does the codim-parameter in
      
        template<int cc>
        unsigned int subIndex (const Codim<cc>::Entity& e,
                               int i,
                               unsigned int codim) const
      
      mean?  Is it the codimension wrt to the grid, or wrt to the entity e?
      I did not find this documented anywhere, and therefore made my own
      choice.  The 'codim' in this patch is the codimension with respect
      to the *grid*.
      
      See merge request !95
      c3b6aed2
    • Carsten Gräser's avatar
      [test] add static check for higher codimension information on grid views · 946694f2
      Carsten Gräser authored and Oliver Sander's avatar Oliver Sander committed
      Until now, the static part of the grid check only check on codim 0 structures,
      e.g., on the index set. This patch also performs these checks on higher
      codimensions.
      
      For the IndexSet::subIndex method, it will only check whether the method
      compiles. If codim > 0, it will silently ignore a Dune::NotImplemented
      exception, so that grids are not forced to implement the method; it simply has
      to compile.
      
      Note: This check is able to detect the error fix in !86.
      946694f2
  7. Oct 13, 2016
Loading