[cleanup][Communication] CollectiveCommunication --> Communication.
Fixes fallout from deprecation in dune-common.
Merge request reports
Activity
added 1 commit
- 22f95e23 - [cleanup][Communication] CollectiveCommunication --> Communication.
added 1 commit
- 371a26f6 - [cleanup][Communication] CollectiveCommunication --> Communication.
added 1 commit
- 39d41012 - [cleanup][Communication] CollectiveCommunication --> Communication.
mentioned in merge request dune-common!1089 (merged)
mentioned in merge request dune-common!1091 (merged)
mentioned in merge request dune-common!1076 (merged)
- Resolved by Christoph Grüninger
Looking good is not enough. This needs to be tested since the fallout downstream could be rather large.
added 1 commit
- e96848df - Document deprecation fo CollectiveCommunication
- Resolved by Christoph Grüninger
added 1 commit
- 2fc12da9 - Document deprecation fo CollectiveCommunication
added 5 commits
-
2fc12da9...db6afbf2 - 2 commits from branch
master
- 9e1005bc - [cleanup][docu] CICollectiveCommunication --> CICommunuication
- 32185d3d - [cleanup][Communication] CollectiveCommunication --> Communication.
- 8a1174d2 - Document deprecation fo CollectiveCommunication
Toggle commit list-
2fc12da9...db6afbf2 - 2 commits from branch
- Resolved by Christoph Grüninger
Perhaps we are running into https://bugs.python.org/issue35182 - but I only just found that with a very brief search and haven't looked at it in detail. Don't know why it never happened before and is happening now - the nightly tests are working without an issue for example.
mentioned in issue dune-common#295 (closed)
added 12 commits
-
8a1174d2...d50215d4 - 9 commits from branch
master
- a4d5c0c0 - [cleanup][docu] CICollectiveCommunication --> CICommunuication
- c4caf2cb - [cleanup][Communication] CollectiveCommunication --> Communication.
- a58ee571 - Document deprecation fo CollectiveCommunication
Toggle commit list-
8a1174d2...d50215d4 - 9 commits from branch
mentioned in merge request dune-common!1125 (merged)
added 5 commits
-
a58ee571...4c8360c4 - 2 commits from branch
master
- 90f1ea92 - [cleanup][docu] CICollectiveCommunication --> CICommunuication
- e206ea21 - [cleanup][Communication] CollectiveCommunication --> Communication.
- f16a8270 - Document deprecation fo CollectiveCommunication
Toggle commit list-
a58ee571...4c8360c4 - 2 commits from branch
added 26 commits
-
f16a8270...3deffdd5 - 23 commits from branch
master
- 37adfb30 - [cleanup][docu] CICollectiveCommunication --> CICommunuication
- 521ef2cb - [cleanup][Communication] CollectiveCommunication --> Communication.
- 6330d65f - Document deprecation fo CollectiveCommunication
Toggle commit list-
f16a8270...3deffdd5 - 23 commits from branch
added 37 commits
-
6330d65f...c77f4d4c - 34 commits from branch
master
- 5e3be0c4 - [cleanup][docu] CICollectiveCommunication --> CICommunuication
- b05f4f26 - [cleanup][Communication] CollectiveCommunication --> Communication.
- bbd92646 - Document deprecation fo CollectiveCommunication
Toggle commit list-
6330d65f...c77f4d4c - 34 commits from branch
I rebased this MR and dune-common!1091 (merged), both pass the pipeline tests.
@tkoch and @robert.kloefkorn, any objections to merging both?
- Resolved by Christoph Grüninger
@gruenich: Seems fine. Did you run the nightly build pipeline (https://gitlab.dune-project.org/infrastructure/dune-nightly-test/-/pipelines)? If that also works with these two branches it can be merged.
mentioned in commit 7f660f69
mentioned in merge request !600 (closed)
@gruenich: Are you going to fix the fallout or should we just leave the master state in complete limbo? The merge of this MR breaks all downstream grid modules unless the Communication typedefs have been provided. These modules are: dune-alugrid and dune0-spgrid (probably fixed), dune-polygongrid, dune-mmesh, opm-grid, ... I have tried to fix it in !600 (closed) but the deprecation warning does not work as expected. So either you come up with a proper solution solution soon (like yesterday) or I will revert !571 (merged).
mentioned in commit ff736472
mentioned in merge request !601 (merged)