Skip to content
Snippets Groups Projects

[cleanup][Communication] CollectiveCommunication --> Communication.

Merged Robert K requested to merge cleanup/collectivecomm into master
All threads resolved!

Fixes fallout from deprecation in dune-common.

Merge request reports

Pipeline #52899 passed

Pipeline passed for bbd92646 on cleanup/collectivecomm

Approval is optional

Merged by Christoph GrüningerChristoph Grüninger 2 years ago (Jul 27, 2022 11:24pm UTC)

Merge details

  • Changes merged into master with 7f660f69.
  • Deleted the source branch.

Pipeline #53031 passed

Pipeline passed for 7f660f69 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I added a commit to have the deprecations more documented.

  • added 1 commit

    • 2fc12da9 - Document deprecation fo CollectiveCommunication

    Compare with previous version

  • Christoph Grüninger resolved all threads

    resolved all threads

  • added 5 commits

    • 2fc12da9...db6afbf2 - 2 commits from branch master
    • 9e1005bc - [cleanup][docu] CICollectiveCommunication --> CICommunuication
    • 32185d3d - [cleanup][Communication] CollectiveCommunication --> Communication.
    • 8a1174d2 - Document deprecation fo CollectiveCommunication

    Compare with previous version

  • added 12 commits

    • 8a1174d2...d50215d4 - 9 commits from branch master
    • a4d5c0c0 - [cleanup][docu] CICollectiveCommunication --> CICommunuication
    • c4caf2cb - [cleanup][Communication] CollectiveCommunication --> Communication.
    • a58ee571 - Document deprecation fo CollectiveCommunication

    Compare with previous version

  • Robert K mentioned in merge request dune-common!1125 (merged)

    mentioned in merge request dune-common!1125 (merged)

  • added 5 commits

    • a58ee571...4c8360c4 - 2 commits from branch master
    • 90f1ea92 - [cleanup][docu] CICollectiveCommunication --> CICommunuication
    • e206ea21 - [cleanup][Communication] CollectiveCommunication --> Communication.
    • f16a8270 - Document deprecation fo CollectiveCommunication

    Compare with previous version

  • Timo Koch added 26 commits

    added 26 commits

    • f16a8270...3deffdd5 - 23 commits from branch master
    • 37adfb30 - [cleanup][docu] CICollectiveCommunication --> CICommunuication
    • 521ef2cb - [cleanup][Communication] CollectiveCommunication --> Communication.
    • 6330d65f - Document deprecation fo CollectiveCommunication

    Compare with previous version

  • added 37 commits

    • 6330d65f...c77f4d4c - 34 commits from branch master
    • 5e3be0c4 - [cleanup][docu] CICollectiveCommunication --> CICommunuication
    • b05f4f26 - [cleanup][Communication] CollectiveCommunication --> Communication.
    • bbd92646 - Document deprecation fo CollectiveCommunication

    Compare with previous version

  • I rebased this MR and dune-common!1091 (merged), both pass the pipeline tests.

    @tkoch and @robert.kloefkorn, any objections to merging both?

  • Christoph Grüninger resolved all threads

    resolved all threads

  • Christoph Grüninger resolved all threads

    resolved all threads

  • mentioned in commit 7f660f69

  • Robert K mentioned in merge request !600 (closed)

    mentioned in merge request !600 (closed)

  • Christoph Grüninger resolved all threads

    resolved all threads

  • @gruenich: Are you going to fix the fallout or should we just leave the master state in complete limbo? The merge of this MR breaks all downstream grid modules unless the Communication typedefs have been provided. These modules are: dune-alugrid and dune0-spgrid (probably fixed), dune-polygongrid, dune-mmesh, opm-grid, ... I have tried to fix it in !600 (closed) but the deprecation warning does not work as expected. So either you come up with a proper solution solution soon (like yesterday) or I will revert !571 (merged).

  • Robert K mentioned in commit ff736472

    mentioned in commit ff736472

  • Robert K mentioned in merge request !601 (merged)

    mentioned in merge request !601 (merged)

  • Please register or sign in to reply
    Loading