[Bugfix] fixed order of the scalar product when applying the Arnoldi algorithm in GMRes solver, which is important in the complex case

minor cleanups in the MinRes solver

[Bugfix] implemented complex Givens rotations and fixed MinRes and GMRes for complex valued problems

The type idxtype is used by header repartition even if parmetis is not
used. Therefore it has to be typedefed meaningful in this case,
too. This was not the case before and is accomplished by this commit.

This was introduced for debugging only and could have side effects
onto other headers. Removes the accidentally committed line.

* feature/fix-gmres-and-minres:
  [GMRes] Fix deprecation warning for old constructors
  made the distinction between field_type and real_type which is the same for real numbers but differs for std::complex
  added the old constructors called with the variable recalc_defect to RestartedGMResSolver and set them as deprecated, since they should not be used anymore
  changed the initialization of the arrays in the MinRes solver to remove the compiler warnings
  fixed MinRes with the following changes:
  fixed GMRes

Conflicts:
	dune/istl/solvers.hh

Function attribute have to be placed in front of the function name,
not behind it.

Marian Piatkowski authored 10 years ago and Steffen Müthing committed 10 years ago

made the distinction between field_type and real_type which is the same for real numbers but differs for std::complex

Marian Piatkowski authored 10 years ago and Steffen Müthing committed 10 years ago

added the old constructors called with the variable recalc_defect to RestartedGMResSolver and set them as deprecated, since they should not be used anymore

Marian Piatkowski authored 11 years ago and Steffen Müthing committed 10 years ago

replaced the usual arrays for the Givens-rotation coefficients and the search directions etc. with the arrays from Dune

implemented the BLAS-routine drotg for greater robustness which was a TODO note to compute the Givens rotation

Marian Piatkowski authored 11 years ago and Steffen Müthing committed 10 years ago

removed bool recalc_defect
reimplement the update function with respect to optimality
fixed strange behaviour when maxiter is reached and GMRes wants to restart infinitely many times
fixed strange behaviour when linear reduction is reached but GMRes wants to restart and continue calculation
fixed the printing of the results

Complained by autoconf 1.14, cf. FS#1462.

This reverts commit 901b5954.
It (METIS) does not seem needed for compilation and the patch
forced the user and downstream modules to add additional compile
 and linker flags.

This reverts commit 6132d0df.
It (METIS) does not seem needed for compilation and the patch
forced the user and downstream modules to add additional compile
 and linker flags.

Unlike the original METIS/ParMETIS scotch does not use extern "C"
in its headers. This lead to linker errors as descibed in
http://lists.dune-project.org/pipermail/dune/2014-March/012745.html.
This patch fixes this by guarding the includes with an extra extern "C"
directive.

Just like for the autotools.

For HAVE_METIS we do not use the ENABLE trick. It is therefore either defined or
not. Therfore using "#if HAVE_METIS" is a bug. This patch fixes this.

There were problems with repartition.hh when using the original parmetis. The cause was
that for scotch we need to require both parmetis.h and metis.h, which broke backwards
compatibility for the original parmetis (which worked without metis, too). With the patch
we check whether parmetis.h is from scotch and if that is the case also require metis. If not,
metis suffices.

Reformat whole CMakeLists.txt file for better readability.

GCC warned about ambiguity between builtin operator*=(double&, int)
and FieldVector<double,i>::operator*=(int), but at least picked one
and just emitted a warning. Clang instead errored out.

To fix this this patch explicitly uses a floating point dampening
factor in the additive version of the AMG.

Fixes flyspray #1456 
https://dune-project.org/flyspray/index.php?do=details&task_id=1456.

To test the implementation improved the test to not only include diagonal block matrices on the
diagonal, because with diagonal left/right multiplication does not make a differece.

The warning has to be silenced by using DUNE_UNUSED_PARAM in dune-common.
This fixes FS#1431.

It was moved to dune-common in Dune 2.3.

Arne Morten Kvarving authored 11 years ago and Markus Blatt committed 11 years ago

Since revision 8df1d996 overlappingschwarz
with UmfPack was broken due to renaming an internal variable accessed by a friend.
This patch fixes this by adding a new private method to access the internal matrix
of solver and uses that for the assembly.