Skip to content
Snippets Groups Projects
  1. Nov 28, 2019
    • Oliver Sander's avatar
      Get rid of the UGGrid::heapSize_ data member · 06b2c40c
      Oliver Sander authored
      The hand-coded memory heap of UG has been removed from dune-uggrid
      about a year ago.  Hence, the heapSize parameter of UGGrid does
      not have any purpose anymore.  This patch removes it completely.
      It only leaves the public method setDefaultHeapSize and marks it
      as deprecated, in order not to break people's codes.
      06b2c40c
  2. Nov 27, 2019
  3. Nov 18, 2019
    • Robert K's avatar
      [!349] Convenience method referenceElement for Entity. · 6401ab3d
      Robert K authored
      Merge branch 'feature/referenceelement' into 'master'
      
      ref:core/dune-grid This MR adds a convenience method referenceElement for the
      entity class. The following will now be possible:
      
          const auto& refElem = referenceElement( entity );
      
          // forwarding the call the referenceElement< ctype, dim > (entity.type() );
      
      A similar method already exists for the Geometry, however, like the method
      type on Entity, building the geometry maybe expensive and therefore using the
      entities' type method is the appropriate choice here.
      
      See merge request [!349]
      
        [!349]: gitlab.dune-project.org/core/dune-grid/merge_requests/349
      6401ab3d
  4. Nov 09, 2019
  5. Oct 22, 2019
  6. Oct 20, 2019
  7. Oct 13, 2019
  8. Sep 30, 2019
    • Oliver Sander's avatar
      [!352] add ctype dependent tolerance to grid tests · ff36065a
      Oliver Sander authored
      Merge branch 'issue/test_tolerances' into 'master'
      
      ref:core/dune-grid
      
      ### Summary
      
      Change the fixed hard coded tolerances in grid tests with something related to
      numeric_limits<ctype>::epsilon().
      
      ### Details
      
      Many tolerances in the grid tests are hard coded to something like 1.e-8.
      Those tests will fail if ctype=float. Thus, all those comparisons are changed
      to either sqrt(numeric_limits<ctype>::epsilon()) or
      numeric_limits<ctype>::epsilon(), depending on the previous value.
      
      ### Discussion
      
      The tolerance values seem quite arbitrary. Sometimes it is compared against
      1.e-8, sometimes 1.e-7 or 1.e-6 or 1e3*numeric_limits<ctype>::epsilon(). Maybe
      it would be cleaner to use the FloatCmp utilities and clearly define what's
      the expected accuracy.
      
      See merge request [!352]
      
        [!352]: gitlab.dune-project.org/core/dune-grid/merge_requests/352
      ff36065a
  9. Sep 27, 2019
  10. Sep 17, 2019
    • Oliver Sander's avatar
      [!354] Properly use SOURCES in dune_add_library · 37ada19c
      Oliver Sander authored
      Merge branch 'use-SOURCES-in-dune-add-library' into 'master'
      
      ref:core/dune-grid dune_add_library implicitly treats all unclaimed trailing
      arguments as source file names, but explicitly marking those as SOURCE makes
      the code more readable.
      
      See merge request [!354]
      
        [!354]: gitlab.dune-project.org/core/dune-grid/merge_requests/354
      37ada19c
    • Oliver Sander's avatar
      Properly use SOURCES in dune_add_library · 07001df0
      Oliver Sander authored
      dune_add_library implicitly treats all unclaimed trailing
      arguments as source file names, but explicitly marking
      those as SOURCE makes the code more readable.
      07001df0
  11. Sep 16, 2019
  12. Sep 05, 2019
  13. Aug 01, 2019
    • Steffen Müthing's avatar
      [!350] Truncate denormalized floating point values to 0 when writing ASCII · d91ccd8c
      Steffen Müthing authored
      Merge branch 'bug/do-not-crash-paraview-on-macos' into 'master'
      
      ref:core/dune-grid Paraview (well, probably VTK) on macOS crashes when reading
      ASCII files with denormalized float values. This seems to be due to libc++'s
      IO stream implementation, which sets the fail bit when reading a denormalized
      value. On top of that, Paraview just segfaults when encountering a fail bit
      while loading VTK files.
      
      libstdc++ does not set the failt bit, and I don't know what is the correct
      behavior, but having Paraview mysteriously crash on DUNE output files is not
      good.
      
      So this patch truncates subnormal floating point values to 0 when writing
      ASCII. This should not seriously influence any visualization results, but it
      might trip up people who use exact floating point comparisons for tests (but
      then you shouldn't do that anyway\...).
      
      See merge request [!350]
      
        [!350]: gitlab.dune-project.org/core/dune-grid/merge_requests/350
      d91ccd8c
    • Steffen Müthing's avatar
    • Steffen Müthing's avatar
      [vtk] Truncate denormalized floating point values to 0 when writing ASCII · 7a86be30
      Steffen Müthing authored
      Paraview (well, probably VTK) on macOS crashes when reading ASCII files with
      denormalized float values. This seems to be due to libc++'s IO stream
      implementation, which sets the fail bit when reading a denormalized value.
      On top of that, Paraview just segfaults when encountering a fail bit while
      loading VTK files.
      
      libstdc++ does not set the failt bit, and I don't know what is the correct
      behavior, but having Paraview mysteriously crash on DUNE output files is not
      good.
      
      So this patch truncates subnormal floating point values to 0 when writing ASCII.
      This should not seriously influence any visualization results, but it might trip
      up people who use exact floating point comparisons for tests (but then you
      shouldn't do that anyway...).
      7a86be30
  14. Jul 18, 2019
  15. Jul 09, 2019
  16. Jul 03, 2019
  17. Jun 18, 2019
    • Ansgar Burchardt's avatar
      [!332] [gridcheck] Only test sum of outer normals for dim=dimworld · ef4e0b77
      Ansgar Burchardt authored
      Merge branch 'feature/sumouternormalerror-warning' into 'master'
      
      ref:core/dune-grid The check is only true for affine elements and if the
      element is not part of a network where intersections can overlap. The 'error'
      will still be propagated as a warning in these cases.
      
      With this change the grid check passes for all tested dune-foamgrid
      configurations which previously failed due to this one check.
      
      See merge request [!332]
      
        [!332]: gitlab.dune-project.org/core/dune-grid/merge_requests/332
      ef4e0b77
    • Ansgar Burchardt's avatar
      [!347] [cleanup] compiler warnings, deprecated stuff · 76d9795d
      Ansgar Burchardt authored
      Merge branch 'cleanup-1' into 'master'
      
      See merge request [!347]
      
        [!347]: Nonecore/dune-grid/merge_requests/347
      76d9795d
    • Ansgar Burchardt's avatar
      remove unused include · 09b45c48
      Ansgar Burchardt authored
      09b45c48
    • Ansgar Burchardt's avatar
      d0006fab
    • Ansgar Burchardt's avatar
      use `TestSuite` instead of `assert(...)` · 69f423d2
      Ansgar Burchardt authored
      `assert(...)` should not be used in tests as it might not be checked
      at all when building with `-DNDEBUG`
      
      This addresses the following compiler warnings from GCC 9:
      
          dune/grid/utility/test/structuredgridfactorytest.cc:89:16:
          warning: unused variable ‘numVertices2d’ [-Wunused-variable]
      
          dune/grid/utility/test/structuredgridfactorytest.cc:90:16:
          warning: unused variable ‘numCubes2d’ [-Wunused-variable]
      
          dune/grid/utility/test/structuredgridfactorytest.cc:164:16:
          warning: unused variable ‘numVertices3d’ [-Wunused-variable]
      
          dune/grid/utility/test/structuredgridfactorytest.cc:165:16:
          warning: unused variable ‘numCubes3d’ [-Wunused-variable]
      69f423d2
  18. Jun 17, 2019
  19. Jun 12, 2019
  20. Jun 11, 2019
  21. Jun 07, 2019
  22. Jun 05, 2019
  23. Jun 03, 2019
    • Oliver Sander's avatar
      [!342] Change type of volume method to typedef · 94015683
      Oliver Sander authored
      Merge branch 'santiago.ospina/dune-grid-feature/change-type-of-volume-method-to-typedef' into 'master'
      
      ref:core/dune-grid This is a rebased version of [!305] \-\-- I seem unable to
      rebase that one in situ.
      
      See merge request [!342]
      
        [!305]: gitlab.dune-project.org/NoneNone/merge_requests/305
        [!342]: gitlab.dune-project.org/core/dune-grid/merge_requests/342
      94015683
Loading