Skip to content
Snippets Groups Projects
  1. Jun 26, 2019
  2. Jun 19, 2019
  3. Jun 18, 2019
  4. Jun 14, 2019
    • Ansgar Burchardt's avatar
      [!684] add explicit capture for `this` · 2e9fde4d
      Ansgar Burchardt authored
      Merge branch 'explicit-capture-for-this' into 'master'
      
      ref:core/dune-common This addresses the following warnings from GCC 9:
      
          dune/common/test/testsuite.hh:78:30: warning: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20 [-Wdeprecated]
          dune/common/test/testsuite.hh:99:30: warning: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20 [-Wdeprecated]
      
      See merge request [!684]
      
        [!684]: gitlab.dune-project.org/core/dune-common/merge_requests/684
      2e9fde4d
    • Ansgar Burchardt's avatar
      add explicit capture for `this` · a05402c4
      Ansgar Burchardt authored
      This addresses the following warnings from GCC 9:
      
          dune/common/test/testsuite.hh:78:30: warning: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20 [-Wdeprecated]
          dune/common/test/testsuite.hh:99:30: warning: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20 [-Wdeprecated]
      
      Note that pre-C++20 does not allow to explicitly capture `this` when
      the default capture is `=`.  So all captures need to be listed.
      Verified
      a05402c4
    • Jö Fahlke's avatar
      [!683] [SIMD] Avoid parameter-passing-abi note, again. · 59d1a167
      Jö Fahlke authored
      Merge branch 'simd-no-abi-warning2' into 'master'
      
      ref:core/dune-common Change all by-value parameters to simd functions that
      might be simd vectors or masks to const-ref parameters. This means they don't
      have to be split into multiple simd registers if the current abi does not have
      large enough registers, I'm guessing.
      
      Closes: [#164] See also: [!607]
      
      WIP:
      
      -   [x] Manually verify the warnings are really gone.
      
      See merge request [!683]
      
        [#164]: gitlab.dune-project.org/NoneNone/issues/164
        [!607]: gitlab.dune-project.org/NoneNone/merge_requests/607
        [!683]: gitlab.dune-project.org/core/dune-common/merge_requests/683
      
      
      Closes #164
      59d1a167
    • Jö Fahlke's avatar
      [SIMD] Avoid parameter-passing-abi note, again. · 1dd39302
      Jö Fahlke authored
      Change all by-value parameters to simd functions that might be simd vectors or
      masks to const-ref parameters.  This means they don't have to be split into
      multiple simd registers if the current abi does not have large enough
      registers, I'm guessing.
      
      Closes: #164
      See also: !607
      1dd39302
    • Jö Fahlke's avatar
      [!682] Changelog: Vc-detected architecture flags · 71455be1
      Jö Fahlke authored
      Merge branch 'vc-architecture-changelog' into 'master'
      
      ref:core/dune-common Closes: [#163]
      
      See merge request [!682]
      
        [#163]: gitlab.dune-project.org/NoneNone/issues/163
        [!682]: gitlab.dune-project.org/core/dune-common/merge_requests/682
      
      
      Closes #163
      71455be1
    • Jö Fahlke's avatar
      Changelog: Vc-detected architecture flags · 82630550
      Jö Fahlke authored
      82630550
    • Jö Fahlke's avatar
      [!680] [CI] Compile the expensive tests with avx again. · 26fc6b83
      Jö Fahlke authored
      Merge branch 'ensure-avx-test' into 'master'
      
      ref:core/dune-common Closes: [#165]
      
      WIP:
      
      -   [x] ensure the Vc vector types really turn out to have the expected size
          (well, we check Vc implementation, but close enough)
      
      See merge request [!680]
      
        [#165]: gitlab.dune-project.org/NoneNone/issues/165
        [!680]: gitlab.dune-project.org/core/dune-common/merge_requests/680
      
      
      Closes #165
      26fc6b83
    • Jö Fahlke's avatar
      CI: Ensure Vc uses SSE2 implementation by default · 8543d148
      Jö Fahlke authored
      Other implementations should only be selected if the compiler is specifically
      told to support them.
      8543d148
  5. Jun 13, 2019
  6. Jun 12, 2019
    • Jö Fahlke's avatar
      [!677] Don't pass the cpu flags detected by Vc to the compiler · 19557065
      Jö Fahlke authored
      Merge branch 'avoid-vc-cpu-detection' into 'master'
      
      ref:core/dune-common Vc detects CPU flags based on the name of the CPU. This
      can be a problem in virtualization environment, when the name of the CPU is
      visible, but not all features are enabled in the guest.
      
      Also, enabling all detected features in the the compiler makes it difficult to
      impossible for the user to force his own feature flags, e.g. to cross-build
      generic executables on hosts with many features to be run later on hosts with
      fewer features.
      
      Closes: [docker/ci#9]
      
      WIP:
      
      -   [x] properly test, in particular in the light of [docker/ci!46] being
          applied to the ci images
      -   [x] ansgar [proposed] getting rid of all the Vc_COMPILE_FLAGS, too. Try
          that: [!679] (redifined [!679] as an add-on to this one, so it does not
          stop me from merging this one)
      -   [x] changelog entry (deferred to [#163])
      
      See merge request [!677]
      
        [docker/ci#9]: gitlab.dune-project.org/docker/ci/issues/9
        [docker/ci!46]: gitlab.dune-project.org/docker/ci/merge_requests/46
        [proposed]: docker/ci#9 (comment 56350)
        [!679]: gitlab.dune-project.org/NoneNone/merge_requests/679
        [#163]: gitlab.dune-project.org/NoneNone/issues/163
        [!677]: gitlab.dune-project.org/core/dune-common/merge_requests/677
      
      
      Closes docker/ci#9
      19557065
    • Oliver Sander's avatar
      [!678] Bugfix: The return type of allreduce is int, not void · 7933d8fc
      Oliver Sander authored
      Merge branch 'fix-return-type-of-sequential-allreduce' into 'master'
      
      See merge request [!678]
      
        [!678]: Nonecore/dune-common/merge_requests/678
      7933d8fc
    • Oliver Sander's avatar
    • Jö Fahlke's avatar
      Don't pass the cpu flags detected by Vc to the compiler · c0bbf1a5
      Jö Fahlke authored
      Vc detects CPU flags based on the name of the CPU.  This can be a problem in
      virtualization environment, when the name of the CPU is visible, but not all
      features are enabled in the guest.
      
      Also, enabling all detected features in the the compiler makes it difficult to
      impossible for the user to force his own feature flags, e.g. to cross-build
      generic executables on hosts with many features to be run later on hosts with
      fewer features.
      
      Closes: docker/ci#9
      c0bbf1a5
  7. May 28, 2019
    • Jö Fahlke's avatar
      [!675] Expect `;` after macro · a028eb31
      Jö Fahlke authored
      Merge branch 'fix-macro-not-expecting-semicolon' into 'master'
      
      ref:core/dune-common This avoids certain compiler warnings about unneccessary
      ;. It plays nicer with automatic editor indentation compared to the the
      alternative of dropping the ; from every invocation of the macro (see [!673]
      for that).
      
      Alternative to: [!673]
      
      WIP:
      
      -   [x] Waiting for feedback from @gruenich
      
      See merge request [!675]
      
        [!673]: gitlab.dune-project.org/NoneNone/merge_requests/673
        [!675]: gitlab.dune-project.org/core/dune-common/merge_requests/675
      a028eb31
    • Jö Fahlke's avatar
      [!674] Fix -Wpessimizing-move warning in integersequence test · b6e34ffb
      Jö Fahlke authored
      Merge branch 'fix/move-on-local-object' into 'master'
      
      See merge request [!674]
      
        [!674]: Nonecore/dune-common/merge_requests/674
      b6e34ffb
  8. May 27, 2019
    • Carsten Gräser's avatar
      [!676] [bugfix] Fix default constructor of Std::variant · d8ec8e8d
      Carsten Gräser authored
      Merge branch 'feature/default-constructible-variant' into 'master'
      
      ref:core/dune-common The behaviour of the default constructor
      `std::variant<T0, ...>` is as follows:
      
      -   \(a) If T0 is default constructible, then the variant will hold a
          value-initialized T0 and the index is 0.
      -   \(b) If T0 is not default constructible, then the default constructor does npt
          participate in overload resolution.
      
      In contrast to this until now the following is implemented
      
      -   \(c) The default constructor of Std::variant does alway exist and will
          initialize it with a special invalid state (which is BTW not copyable).
      
      Having (c) instead of (a) especially prevented copying default constructed
      `Std::variant<Std::monostate, ...>` objects.
      
      This patch at least ensures (a) but keeps (c) if T0 is not default
      constructible. The reason for the latter is, that (b) is much harder to fix
      and unlikely to lead to problems.
      
      See merge request [!676]
      
        [!676]: gitlab.dune-project.org/core/dune-common/merge_requests/676
      d8ec8e8d
    • Carsten Gräser's avatar
      Add missing include · 933530a1
      Carsten Gräser authored
      933530a1
    • Carsten Gräser's avatar
      [bugfix] Fix default constructor of Std::variant · 966087b2
      Carsten Gräser authored
      The behaviour of the default constructor `std::variant<T0, ...>` is as follows:
      
      * (a) If `T0` is default constructible, then the `variant` will hold
        a value-initialized `T0` and the index is 0.
      * (b) If `T0` is not default constructible, then the default constructor
        does npt participate in overload resolution.
      
      In contrast to this until now the following is implemented
      
      * (c) The default constructor of `Std::variant` does alway exist
        and will initialize it with a special invalid state (which
        is BTW not copyable).
      
      Having (c) instead of (a) especially prevented copying default
      constructed `Std::variant<Std::monostate, ...>` objects.
      
      This patch at least ensures (a) but keeps (c) if `T0` is not
      default constructible. The reason for the latter is, that (b)
      is much harder to fix and unlikely to lead to problems.
      966087b2
    • Jö Fahlke's avatar
      Expect `;` after macro · 730c5bce
      Jö Fahlke authored
      This avoids certain compiler warnings about unneccessary `;`.  It plays nicer
      with automatic editor indentation compared to the the alternative of dropping
      the `;` from every invocation of the macro (see !673 for that).
      730c5bce
  9. May 26, 2019
  10. May 10, 2019
Loading