1. 17 Sep, 2019 2 commits
    • Oliver Sander's avatar
      [!354] Properly use SOURCES in dune_add_library · 37ada19c
      Oliver Sander authored
      Merge branch 'use-SOURCES-in-dune-add-library' into 'master'
      
      ref:core/dune-grid dune_add_library implicitly treats all unclaimed trailing
      arguments as source file names, but explicitly marking those as SOURCE makes
      the code more readable.
      
      See merge request [!354]
      
        [!354]: gitlab.dune-project.org/core/dune-grid/merge_requests/354
      37ada19c
    • Oliver Sander's avatar
      Properly use SOURCES in dune_add_library · 07001df0
      Oliver Sander authored
      dune_add_library implicitly treats all unclaimed trailing
      arguments as source file names, but explicitly marking
      those as SOURCE makes the code more readable.
      07001df0
  2. 01 Aug, 2019 3 commits
    • Steffen Müthing's avatar
      [!350] Truncate denormalized floating point values to 0 when writing ASCII · d91ccd8c
      Steffen Müthing authored
      Merge branch 'bug/do-not-crash-paraview-on-macos' into 'master'
      
      ref:core/dune-grid Paraview (well, probably VTK) on macOS crashes when reading
      ASCII files with denormalized float values. This seems to be due to libc++'s
      IO stream implementation, which sets the fail bit when reading a denormalized
      value. On top of that, Paraview just segfaults when encountering a fail bit
      while loading VTK files.
      
      libstdc++ does not set the failt bit, and I don't know what is the correct
      behavior, but having Paraview mysteriously crash on DUNE output files is not
      good.
      
      So this patch truncates subnormal floating point values to 0 when writing
      ASCII. This should not seriously influence any visualization results, but it
      might trip up people who use exact floating point comparisons for tests (but
      then you shouldn't do that anyway\...).
      
      See merge request [!350]
      
        [!350]: gitlab.dune-project.org/core/dune-grid/merge_requests/350
      d91ccd8c
    • Steffen Müthing's avatar
    • Steffen Müthing's avatar
      [vtk] Truncate denormalized floating point values to 0 when writing ASCII · 7a86be30
      Steffen Müthing authored
      Paraview (well, probably VTK) on macOS crashes when reading ASCII files with
      denormalized float values. This seems to be due to libc++'s IO stream
      implementation, which sets the fail bit when reading a denormalized value.
      On top of that, Paraview just segfaults when encountering a fail bit while
      loading VTK files.
      
      libstdc++ does not set the failt bit, and I don't know what is the correct
      behavior, but having Paraview mysteriously crash on DUNE output files is not
      good.
      
      So this patch truncates subnormal floating point values to 0 when writing ASCII.
      This should not seriously influence any visualization results, but it might trip
      up people who use exact floating point comparisons for tests (but then you
      shouldn't do that anyway...).
      7a86be30
  3. 18 Jul, 2019 1 commit
  4. 09 Jul, 2019 3 commits
  5. 03 Jul, 2019 1 commit
  6. 18 Jun, 2019 5 commits
    • Ansgar Burchardt's avatar
      [!332] [gridcheck] Only test sum of outer normals for dim=dimworld · ef4e0b77
      Ansgar Burchardt authored
      Merge branch 'feature/sumouternormalerror-warning' into 'master'
      
      ref:core/dune-grid The check is only true for affine elements and if the
      element is not part of a network where intersections can overlap. The 'error'
      will still be propagated as a warning in these cases.
      
      With this change the grid check passes for all tested dune-foamgrid
      configurations which previously failed due to this one check.
      
      See merge request [!332]
      
        [!332]: gitlab.dune-project.org/core/dune-grid/merge_requests/332
      ef4e0b77
    • Ansgar Burchardt's avatar
      [!347] [cleanup] compiler warnings, deprecated stuff · 76d9795d
      Ansgar Burchardt authored
      Merge branch 'cleanup-1' into 'master'
      
      See merge request [!347]
      
        [!347]: Nonecore/dune-grid/merge_requests/347
      76d9795d
    • Ansgar Burchardt's avatar
      remove unused include · 09b45c48
      Ansgar Burchardt authored
      09b45c48
    • Ansgar Burchardt's avatar
      d0006fab
    • Ansgar Burchardt's avatar
      use `TestSuite` instead of `assert(...)` · 69f423d2
      Ansgar Burchardt authored
      `assert(...)` should not be used in tests as it might not be checked
      at all when building with `-DNDEBUG`
      
      This addresses the following compiler warnings from GCC 9:
      
          dune/grid/utility/test/structuredgridfactorytest.cc:89:16:
          warning: unused variable ‘numVertices2d’ [-Wunused-variable]
      
          dune/grid/utility/test/structuredgridfactorytest.cc:90:16:
          warning: unused variable ‘numCubes2d’ [-Wunused-variable]
      
          dune/grid/utility/test/structuredgridfactorytest.cc:164:16:
          warning: unused variable ‘numVertices3d’ [-Wunused-variable]
      
          dune/grid/utility/test/structuredgridfactorytest.cc:165:16:
          warning: unused variable ‘numCubes3d’ [-Wunused-variable]
      69f423d2
  7. 17 Jun, 2019 1 commit
  8. 12 Jun, 2019 1 commit
  9. 11 Jun, 2019 2 commits
  10. 07 Jun, 2019 2 commits
  11. 05 Jun, 2019 2 commits
  12. 03 Jun, 2019 1 commit
    • Oliver Sander's avatar
      [!342] Change type of volume method to typedef · 94015683
      Oliver Sander authored
      Merge branch 'santiago.ospina/dune-grid-feature/change-type-of-volume-method-to-typedef' into 'master'
      
      ref:core/dune-grid This is a rebased version of [!305] \-\-- I seem unable to
      rebase that one in situ.
      
      See merge request [!342]
      
        [!305]: gitlab.dune-project.org/NoneNone/merge_requests/305
        [!342]: gitlab.dune-project.org/core/dune-grid/merge_requests/342
      94015683
  13. 01 Jun, 2019 2 commits
    • Santiago Ospina's avatar
      Make Geometry export the return type of the 'volume' method · e06f16d8
      Santiago Ospina authored
      Previously this was 'ctype', but grids may care about proper
      dimensions.  In that case, a volume is not the same as a
      coordinate, and a separate type for volumes is necessary.
      
      The interface class does not hard-wire any type but rather exports
      the type used by the Geometry implementation class.  That type
      is determined by introspection, there is no need to adapt
      downstream grid implementations.
      e06f16d8
    • Jö Fahlke's avatar
      [!341] Remove std::move from hierachic seach · 6f10b0ec
      Jö Fahlke authored
      Merge branch 'fix/gcc-9-warnings' into 'master'
      
      ref:core/dune-grid Indicated by GCC 9's -Wpessimizing-move
      
      See merge request [!341]
      
        [!341]: gitlab.dune-project.org/core/dune-grid/merge_requests/341
      6f10b0ec
  14. 31 May, 2019 1 commit
  15. 29 May, 2019 4 commits
    • Ansgar Burchardt's avatar
      [!338] remove deprecated warning in albertagrid backuprestore facilities · a8052ebe
      Ansgar Burchardt authored
      Merge branch 'issue/alberta_backuprestore_warning' into 'master'
      
      ref:core/dune-grid
      
      ### Summary
      
      Remove the usage of writeGridXdr and readGridXdr in AlbertaGrid since is
      produces a deprecated warning.
      
      ### Details
      
      The functions writeGridXdr and readGridXdr were simplified to writeGrid and
      readGrid some time ago, but used in the backup-restore facilities of the
      AlbertaGrid. This emits a deprecated warning all the time. This MR, replaces
      the old functions with the new ones.
      
      See merge request [!338]
      
        [!338]: gitlab.dune-project.org/core/dune-grid/merge_requests/338
      a8052ebe
    • Steffen Müthing's avatar
      [!340] Changed hasBackupRestoreFacilities for GeometryGrid [bugfix] · ac8cba05
      Steffen Müthing authored
      Merge branch 'issue/geometrygrid_backuprestore_coordfunction' into 'master'
      
      ref:core/dune-grid
      
      ### Summary
      
      Changes GeometryGrid capabilities to be true for hasBackupRestoreFacilities
      only if the CoordFunction is default constructible
      
      ### Details
      
      Instantiating the BackupRestoreFacilities::restore for
      `GeometryGrid<HostGrid, CoordFunction>` with a CoordFunction that is not
      default constructible leads to an error. This is in contrast to the capability
      hasBackupRestoreFacilities that returns true for this grid.
      
      This MR updates the capabilities to be false if the CoordsFunction is not
      default constructible and adds a tag-dispatching with a runtime-error in case
      someone instantiates the BackupRestoreFacilities with such a CoordsFunction
      nevertheless.
      
      So, the BackupRestoreFacilities can be instantiated without a compile-time
      error and one can use the hasBackupRestoreFacilities for a compile-time check
      whether this should work or not.
      
      ### See Also
      
      Some discussions about how to restore a non-default-constructible
      CoordFunction can be found in [!339]
      
      See merge request [!340]
      
        [!339]: gitlab.dune-project.org/NoneNone/merge_requests/339
        [!340]: gitlab.dune-project.org/core/dune-grid/merge_requests/340
      ac8cba05
    • Simon Praetorius's avatar
    • Simon Praetorius's avatar
      changed geometrygrid capabilities to be true for backup-restore only if... · 959a8bad
      Simon Praetorius authored
      changed geometrygrid capabilities to be true for backup-restore only if coordfunction is default constructible
      959a8bad
  16. 28 May, 2019 1 commit
  17. 23 May, 2019 2 commits
  18. 21 May, 2019 2 commits
  19. 17 May, 2019 2 commits
  20. 16 May, 2019 2 commits