1. 28 Mar, 2020 3 commits
  2. 25 Mar, 2020 1 commit
  3. 23 Mar, 2020 1 commit
  4. 21 Mar, 2020 1 commit
    • Oliver Sander's avatar
      [!396] Make UGGrid LBMessageBuffer depend on the data type · f9596238
      Oliver Sander authored
      Merge branch 'make-uggrid-message-buffer-more-robust' into 'master'
      
      ref:core/dune-grid\> Previously, the methods LBMessageBuffer::read and
      LBMessageBuffer::write depended on the DataType, but the LBMessageBuffer class
      itself did not. This lead to subtle bugs: I wanted to send a vector of
      doubles, stored in a std::map. By error, I set the DataType to
      std::map::value_type, which is a std::pair\<IdType,double\> rather than to the
      correct type std::map::mapped_type (aka double). Still, my DataHandle only
      wrote double values into the message buffer, which lead to strange memory
      corruption.
      
      This patch makes sure the compiler finds such a bug.
      
      See merge request [!396]
      
        [!396]: gitlab.dune-project.org/core/dune-grid/merge_requests/396
      f9596238
  5. 20 Mar, 2020 2 commits
    • Oliver Sander's avatar
      Make UGGrid LBMessageBuffer depend on the data type · a826381e
      Oliver Sander authored
      Previously, the methods LBMessageBuffer::read and LBMessageBuffer::write
      depended on the DataType, but the LBMessageBuffer class itself did not.
      This lead to subtle bugs:  I wanted to send a vector of doubles, stored in a
      std::map.  By error, I set the DataType to std::map::value_type,
      which is a std::pair<IdType,double> rather than to the correct
      type std::map::mapped_type (aka double).  Still, my DataHandle only wrote double
      values into the message buffer, which lead to strange memory corruption.
      
      This patch makes sure the compiler finds such a bug.
      a826381e
    • Robert K's avatar
      [!393] [bugfix][fixedsize] Fix deprecation warning for fixedsize and derived fixedsize. · 9dda4540
      Robert K authored
      Merge branch 'bugfix/fixedsize-deprecation' into 'master'
      
      ref:core/dune-grid\> This fixes [#105] and also warns about fixedSize not
      being overloaded.
      
      See merge request [!393]
      
        [#105]: gitlab.dune-project.org/NoneNone/issues/105
        [!393]: gitlab.dune-project.org/core/dune-grid/merge_requests/393
      
      
      Closes #105
      9dda4540
  6. 19 Mar, 2020 4 commits
  7. 18 Mar, 2020 2 commits
  8. 17 Mar, 2020 1 commit
  9. 15 Mar, 2020 2 commits
    • Jö Fahlke's avatar
      [!391] add using std::sqrt · af580956
      Jö Fahlke authored
      Merge branch 'add_using_std__sqrt' into 'master'
      
      ref:core/dune-grid\> In the last time I stumbled over error messages like
      
          error: no matching function for call to ‘sqrt(double)‘
      
      a lot. The problem is that loop.hh in dune-common, defines the cmath functions
      in the Dune namespace, which are the found by the unqualified name lookup
      before the declarations in the namespace std. This merge request adds using
      directives everywhere sqrt is used to avoid this problem. Additionally it
      probably removes the name qualifier std:: before sqrt.
      
      See merge request [!391]
      
        [!391]: gitlab.dune-project.org/core/dune-grid/merge_requests/391
      af580956
    • Nils-Arne Dreier's avatar
      add using std::sqrt · e5c9a748
      Nils-Arne Dreier authored
      e5c9a748
  10. 13 Mar, 2020 5 commits
  11. 12 Mar, 2020 2 commits
  12. 07 Mar, 2020 2 commits
    • Jö Fahlke's avatar
      [!381] GmshReader: more flexible and robust io-arg-style interface for reading data · 39390f7c
      Jö Fahlke authored
      Merge branch 'fs1698-new-gmshreader-iface-io-arg-style' into 'master'
      
      ref:core/dune-grid\> This allows the user to not pass the data vectors he/she
      is not interested in. To ignore a vector, pass std::ignore.
      
      In addition, in place of the boundary segment data a bool value may be passed,
      stating whether or not to insert boundary segments. false is equivalent to
      std::ignore and no boundary segments are inserted. When a vector to fill is
      given, boundary segments are always inserted (otherwise the user would be
      unable to correctly index that vector).
      
      In summary, given
      
          GridFactory<Grid> factory;
          std::vector<int> boundaryData, elementData;
          using Reader = GmshReader<Grid>;
          bool verbose = ...;
          bool insertBoundarySegments = ...;
      
      the following uses are now possible:
      
          Reader::read(factory, "file.msh", boundaryData, elementData, verbose);
          Reader::read(factory, "file.msh", boundaryData, std::ignore, verbose);
          Reader::read(factory, "file.msh", std::ignore, elementData, verbose);
          Reader::read(factory, "file.msh", std::ignore, std::ignore, verbose);
          Reader::read(factory, "file.msh", insertBoundarySegments, elementData, verbose);
          Reader::read(factory, "file.msh", insertBoundarySegments, std::ignore, verbose);
      
      In each of those, the verbose argument is optional.
      
      Addresses: [flyspray/FS#1698]
      
      WIP:
      
      -   [x] Wait until 2020-03-01 for comments.
      
      See merge request [!381]
      
        [flyspray/FS#1698]: gitlab.dune-project.org/flyspray/FS/issues/1698
        [!381]: gitlab.dune-project.org/core/dune-grid/merge_requests/381
      39390f7c
    • Jö Fahlke's avatar
      [!379] GridFactory: adapt to function.hh deprecation · 1f073d07
      Jö Fahlke authored
      Merge branch 'gridfactory-follow-function.hh-deprecation' into 'master'
      
      ref:core/dune-grid\> Gridfactory used VirtualFunction as the interface to
      describe parameterized elements. This replaces that by an interface using
      std::function. The old interface is deprecated.
      
      For the deprecation period, the new interface function forwards to the old
      interface in the abstract base class.
      
      WIP:
      
      -   [x] Sent [mail] to dune-devel asking about parameterized insertElement()
      -   [x] Wait for comments until 2020-02-29 before merge
      -   [x] Coordinate with dune-foamgrid
      -   [x] Combed through the (external) grids listed on our homepage, none seem
          to use the parameterized insertElement(). dune-curvilineargrid seems to
          support something like that, but through a different interface. And
          dune-foamgrid is already listed above.
      
      See merge request [!379]
      
        [mail]: https://lists.dune-project.org/pipermail/dune-devel/2020-February/002543.html
        [!379]: gitlab.dune-project.org/core/dune-grid/merge_requests/379
      1f073d07
  13. 03 Mar, 2020 7 commits
  14. 26 Feb, 2020 2 commits
    • Oliver Sander's avatar
      [!389] Make test-parallel-ug less noisy · 00293a89
      Oliver Sander authored
      Merge branch 'make-test-parallel-ug-less-noisy' into 'master'
      
      ref:core/dune-grid\> That test just printed way too much stuff to the console.
      This patch removes some of it, and redirects most of the rest from std::cout
      to Dune::dverb.
      
      See merge request [!389]
      
        [!389]: gitlab.dune-project.org/core/dune-grid/merge_requests/389
      00293a89
    • Oliver Sander's avatar
      Make test-parallel-ug less noisy · d0392b40
      Oliver Sander authored
      That test just printed way too much stuff to the console.
      This patch removes some of it, and redirects most of the
      rest from std::cout to Dune::dverb.
      d0392b40
  15. 23 Feb, 2020 1 commit
  16. 22 Feb, 2020 1 commit
  17. 21 Feb, 2020 2 commits
    • Oliver Sander's avatar
      [!382] Inline the UG ConfigureCommand and NewCommand methods · d068c3c0
      Oliver Sander authored
      Merge branch 'merge-uggrid-commands' into 'master'
      
      ref:core/dune-grid These are a left-over from the day when we had to
      communicate with UG through its command interpreter. These days are long gone,
      and we can now simply call the relevant methods in dune-uggrid directly. This
      leads to some code simplification.
      
      See merge request [!382]
      
        [!382]: gitlab.dune-project.org/core/dune-grid/merge_requests/382
      d068c3c0
    • Oliver Sander's avatar
      Inline the UG ConfigureCommand and NewCommand methods · 5067dedb
      Oliver Sander authored
      These are a left-over from the day when we had to communicate
      with UG through its command interpreter.  These days are long gone,
      and we can now simply call the relevant methods in dune-uggrid
      directly.  This leads to some code simplification.
      5067dedb
  18. 16 Feb, 2020 1 commit
    • Jö Fahlke's avatar
      GmshReader: more flexible and robust io-arg-style interface for reading data · 7a333d38
      Jö Fahlke authored
      This allows the user to not pass the data vectors he/she is not interested in.
      To ignore a vector, pass `std::ignore`.
      
      In addition, in place of the boundary segment data a `bool` value may be
      passed, stating whether or not to insert boundary segments.  `false` is
      equivalent to `std::ignore` and no boundary segments are inserted.  When a
      vector to fill is given, boundary segments are always inserted (otherwise the
      user would be unable to correctly index that vector).
      7a333d38