1. 09 Jul, 2019 3 commits
  2. 03 Jul, 2019 1 commit
  3. 18 Jun, 2019 5 commits
    • Ansgar Burchardt's avatar
      [!332] [gridcheck] Only test sum of outer normals for dim=dimworld · ef4e0b77
      Ansgar Burchardt authored
      Merge branch 'feature/sumouternormalerror-warning' into 'master'
      
      ref:core/dune-grid The check is only true for affine elements and if the
      element is not part of a network where intersections can overlap. The 'error'
      will still be propagated as a warning in these cases.
      
      With this change the grid check passes for all tested dune-foamgrid
      configurations which previously failed due to this one check.
      
      See merge request [!332]
      
        [!332]: gitlab.dune-project.org/core/dune-grid/merge_requests/332
      ef4e0b77
    • Ansgar Burchardt's avatar
      [!347] [cleanup] compiler warnings, deprecated stuff · 76d9795d
      Ansgar Burchardt authored
      Merge branch 'cleanup-1' into 'master'
      
      See merge request [!347]
      
        [!347]: Nonecore/dune-grid/merge_requests/347
      76d9795d
    • Ansgar Burchardt's avatar
      remove unused include · 09b45c48
      Ansgar Burchardt authored
      09b45c48
    • Ansgar Burchardt's avatar
      d0006fab
    • Ansgar Burchardt's avatar
      use `TestSuite` instead of `assert(...)` · 69f423d2
      Ansgar Burchardt authored
      `assert(...)` should not be used in tests as it might not be checked
      at all when building with `-DNDEBUG`
      
      This addresses the following compiler warnings from GCC 9:
      
          dune/grid/utility/test/structuredgridfactorytest.cc:89:16:
          warning: unused variable ‘numVertices2d’ [-Wunused-variable]
      
          dune/grid/utility/test/structuredgridfactorytest.cc:90:16:
          warning: unused variable ‘numCubes2d’ [-Wunused-variable]
      
          dune/grid/utility/test/structuredgridfactorytest.cc:164:16:
          warning: unused variable ‘numVertices3d’ [-Wunused-variable]
      
          dune/grid/utility/test/structuredgridfactorytest.cc:165:16:
          warning: unused variable ‘numCubes3d’ [-Wunused-variable]
      69f423d2
  4. 17 Jun, 2019 1 commit
  5. 12 Jun, 2019 1 commit
  6. 11 Jun, 2019 2 commits
  7. 07 Jun, 2019 2 commits
  8. 05 Jun, 2019 2 commits
  9. 03 Jun, 2019 1 commit
    • Oliver Sander's avatar
      [!342] Change type of volume method to typedef · 94015683
      Oliver Sander authored
      Merge branch 'santiago.ospina/dune-grid-feature/change-type-of-volume-method-to-typedef' into 'master'
      
      ref:core/dune-grid This is a rebased version of [!305] \-\-- I seem unable to
      rebase that one in situ.
      
      See merge request [!342]
      
        [!305]: gitlab.dune-project.org/NoneNone/merge_requests/305
        [!342]: gitlab.dune-project.org/core/dune-grid/merge_requests/342
      94015683
  10. 01 Jun, 2019 2 commits
    • Santiago Ospina's avatar
      Make Geometry export the return type of the 'volume' method · e06f16d8
      Santiago Ospina authored
      Previously this was 'ctype', but grids may care about proper
      dimensions.  In that case, a volume is not the same as a
      coordinate, and a separate type for volumes is necessary.
      
      The interface class does not hard-wire any type but rather exports
      the type used by the Geometry implementation class.  That type
      is determined by introspection, there is no need to adapt
      downstream grid implementations.
      e06f16d8
    • Jö Fahlke's avatar
      [!341] Remove std::move from hierachic seach · 6f10b0ec
      Jö Fahlke authored
      Merge branch 'fix/gcc-9-warnings' into 'master'
      
      ref:core/dune-grid Indicated by GCC 9's -Wpessimizing-move
      
      See merge request [!341]
      
        [!341]: gitlab.dune-project.org/core/dune-grid/merge_requests/341
      6f10b0ec
  11. 31 May, 2019 1 commit
  12. 29 May, 2019 4 commits
    • Ansgar Burchardt's avatar
      [!338] remove deprecated warning in albertagrid backuprestore facilities · a8052ebe
      Ansgar Burchardt authored
      Merge branch 'issue/alberta_backuprestore_warning' into 'master'
      
      ref:core/dune-grid
      
      ### Summary
      
      Remove the usage of writeGridXdr and readGridXdr in AlbertaGrid since is
      produces a deprecated warning.
      
      ### Details
      
      The functions writeGridXdr and readGridXdr were simplified to writeGrid and
      readGrid some time ago, but used in the backup-restore facilities of the
      AlbertaGrid. This emits a deprecated warning all the time. This MR, replaces
      the old functions with the new ones.
      
      See merge request [!338]
      
        [!338]: gitlab.dune-project.org/core/dune-grid/merge_requests/338
      a8052ebe
    • Steffen Müthing's avatar
      [!340] Changed hasBackupRestoreFacilities for GeometryGrid [bugfix] · ac8cba05
      Steffen Müthing authored
      Merge branch 'issue/geometrygrid_backuprestore_coordfunction' into 'master'
      
      ref:core/dune-grid
      
      ### Summary
      
      Changes GeometryGrid capabilities to be true for hasBackupRestoreFacilities
      only if the CoordFunction is default constructible
      
      ### Details
      
      Instantiating the BackupRestoreFacilities::restore for
      `GeometryGrid<HostGrid, CoordFunction>` with a CoordFunction that is not
      default constructible leads to an error. This is in contrast to the capability
      hasBackupRestoreFacilities that returns true for this grid.
      
      This MR updates the capabilities to be false if the CoordsFunction is not
      default constructible and adds a tag-dispatching with a runtime-error in case
      someone instantiates the BackupRestoreFacilities with such a CoordsFunction
      nevertheless.
      
      So, the BackupRestoreFacilities can be instantiated without a compile-time
      error and one can use the hasBackupRestoreFacilities for a compile-time check
      whether this should work or not.
      
      ### See Also
      
      Some discussions about how to restore a non-default-constructible
      CoordFunction can be found in [!339]
      
      See merge request [!340]
      
        [!339]: gitlab.dune-project.org/NoneNone/merge_requests/339
        [!340]: gitlab.dune-project.org/core/dune-grid/merge_requests/340
      ac8cba05
    • Simon Praetorius's avatar
    • Simon Praetorius's avatar
      changed geometrygrid capabilities to be true for backup-restore only if... · 959a8bad
      Simon Praetorius authored
      changed geometrygrid capabilities to be true for backup-restore only if coordfunction is default constructible
      959a8bad
  13. 28 May, 2019 1 commit
  14. 23 May, 2019 2 commits
  15. 21 May, 2019 2 commits
  16. 17 May, 2019 2 commits
  17. 16 May, 2019 2 commits
  18. 04 Apr, 2019 1 commit
    • Carsten Gräser's avatar
      [!330] Avoid unused variable warning without MPI · 0500649f
      Carsten Gräser authored
      Merge branch 'feature/yaspgrid-avoid-unused-variable' into 'master'
      
      ref:core/dune-grid Whatever the mysterious meaning of the mysteryFactor is,
      it's only used in the `#if HAVE_MPI` branch. Hence we should move it there to
      avoid unused variable warnings.
      
      See merge request [!330]
      
        [!330]: gitlab.dune-project.org/core/dune-grid/merge_requests/330
      0500649f
  19. 03 Apr, 2019 2 commits
  20. 29 Mar, 2019 1 commit
  21. 26 Mar, 2019 1 commit
  22. 25 Mar, 2019 1 commit
    • Robert K's avatar
      [!325] Distributed boundary segments. · 8fe069ca
      Robert K authored
      Merge branch 'feature/distributed-boundary-segments' into 'master'
      
      ref:core/dune-grid This MR implements a missing feature in the grid interface,
      the possibility to distribute boundary segments during load balancing. This
      create a problem, because grid readers such as GmshReader only read grid on
      rank 0, and thus boundary segments only exist on that rank. So far there was
      not possibility to re-distribute these segments leading to false boundary
      projections in parallel computations. This MR implements this by providing a
      BoundarySegmentBackupRestore class that allows to re-create a boundary segment
      from a stringstream (char buffer). This requires the registry of a static
      function that can restore the correct object from the stream. The factory is
      necessary because of the type erasure when passing pointers of BoundarySegment
      to the GridFactory. This also means a slight interface change for GmshReader.
      The methods of GmshReader, such as GmshReader::read have to be called on all
      ranks, because the correct BoundarySegment factory methods have to be
      registered on all cores. As before reading is only done on core 0 which
      already was checked in GmshReader before. The other implementation concerns
      the DGF::ProjectionBlock where the boundary projections are now also
      distributable.
      
      Testing has been done with a corresponding branch on dune-alugrid.
      
      See merge request [!325]
      
        [!325]: gitlab.dune-project.org/core/dune-grid/merge_requests/325
      8fe069ca