Skip to content
Snippets Groups Projects
  1. Feb 06, 2020
    • Markus Blatt's avatar
      [!761] [cmake] Use actual build program for Fortran test · 2332bf4a
      Markus Blatt authored
      Merge branch 'feature/support-manually-set-ninja-in-fortran-test' into 'master'
      
      ref:core/dune-common Prior to this change the build program (make, Ninja) was
      not identical to the one used by CMake, but the one installed on the system.
      
      I found this when testing Fortran support of upcoming CMake 3.17 with upcoming
      Ninja 1.10 - which works!
      
      See merge request [!761]
      
        [!761]: gitlab.dune-project.org/core/dune-common/merge_requests/761
      2332bf4a
  2. Jan 30, 2020
  3. Jan 26, 2020
  4. Jan 23, 2020
  5. Jan 21, 2020
    • Ansgar Burchardt's avatar
      [!758] fix C++20 and GCC 10 issues · a9fbe94d
      Ansgar Burchardt authored
      Merge branch 'gcc10' into 'master'
      
      See merge request [!758]
      
        [!758]: Nonecore/dune-common/merge_requests/758
      a9fbe94d
    • Ansgar Burchardt's avatar
      [GCC 10] do not test SIMD with wide character types · 98e4122a
      Ansgar Burchardt authored
      GCC 10's libstdc++ deleted some `operator<<` overloads to write wide
      characters to non-wide streams as these would be treated as integers
      instead of characters. One could use wide variants `wstringstream`,
      `wstring` instead of the usual `stringstream`, `string`, but at some
      places would have to convert between different character
      representations.
      
      As wide characters really should only be used for text, DUNE doesn't
      really need to support them as numerical types here. So we just drop
      the tests using wide character types.
      
      This addresses compiler errors like
      ```
      ../dune/common/simd/test.hh:1732:20: error: use of deleted function ‘std::basic_ostream<char, _Traits>& std::operator<<(std::basic_ostream<char, _Traits>&, wchar_t) [with _Traits = std::char_traits<char>]’
      In file included from /usr/include/c++/10/iostream:39,
                       from ../dune/common/simd/test.hh:12,
                       from dune/common/simd/test/standardtest_vector_wchar_t.cc:5:
      /usr/include/c++/10/ostream:538:5: note: declared here
        538 |     operator<<(basic_ostream<char, _Traits>&, wchar_t) = delete;
      ```
      98e4122a
    • Ansgar Burchardt's avatar
      [C++20] use `std::allocator_traits` · b65b1e2c
      Ansgar Burchardt authored
      Several members of `std::allocator` were already deprecated in C++17
      and have now been removed in C++20. This patch uses the appropriate
      members of `std::allocator_traits` instead.
      b65b1e2c
    • Simon Praetorius's avatar
  6. Jan 19, 2020
  7. Jan 17, 2020
  8. Jan 10, 2020
  9. Jan 08, 2020
  10. Jan 07, 2020
  11. Jan 02, 2020
    • Christian Engwer's avatar
      [python][cmake] fix handling of venv parameters · b1864f5d
      Christian Engwer authored
      cmake parameters are passed as a list. The "-p ${PYTHON_EXECUTABLE}"
      ption was passed as string, which lead to problems setting up the venv
      on my Debian testing system.
      
      We now pass all parameters as lists, just like it should be....
      b1864f5d
  12. Dec 28, 2019
  13. Dec 20, 2019
  14. Dec 19, 2019
    • Christoph Grüninger's avatar
      Bump version to 2.8 · c59698c3
      Christoph Grüninger authored
      c59698c3
    • Christoph Grüninger's avatar
      [!738] Deprecate *collectivecommunication.hh headers. · 2d911e53
      Christoph Grüninger authored
      Merge branch 'feature/deprecate-collective-headers' into 'master'
      
      ref:core/dune-common They will be removed after Dune 2.7.
      
      See merge request [!738]
      
        [!738]: gitlab.dune-project.org/core/dune-common/merge_requests/738
      2d911e53
    • Christoph Grüninger's avatar
      Deprecate *collectivecommunication.hh headers. · cf4c6263
      Christoph Grüninger authored
      They will be removed after Dune 2.7.
      cf4c6263
    • Christoph Grüninger's avatar
      [!737] Add copy-constructor and copy-assign to VariableSizeCommunicator · fcfd0eb4
      Christoph Grüninger authored
      Merge branch 'feature/variablesizecomm-copy' into 'master'
      
      ref:core/dune-common This basically implements the rule of 3, as we have a
      custom destructor. Without this patch, copying a VariableSizeCommunicator will
      lead to double frees.
      
      Supersedes [!690]
      
      See merge request [!737]
      
        [!690]: gitlab.dune-project.org/NoneNone/merge_requests/690
        [!737]: gitlab.dune-project.org/core/dune-common/merge_requests/737
      fcfd0eb4
    • Lasse Hinrichsen-Bischoff's avatar
      Add copy-constructor and copy-assign to VariableSizeCommunicator · 2652f929
      Lasse Hinrichsen-Bischoff authored and Christoph Grüninger's avatar Christoph Grüninger committed
      This basically implements the rule of 3, as we have a custom destructor.
      Without this patch, copying a VariableSizeCommunicator will lead to double frees.
      2652f929
    • Christoph Grüninger's avatar
      [!736] cmake: separate commandline args to list · 13411d62
      Christoph Grüninger authored
      Merge branch 'fix/mpi-cmake' into 'master'
      
      ref:core/dune-common Providing space-separated MPI_DUNE_COMPILE_FLAGS would
      previously add them as a single list entry to the cmake list COMPILE_OPTIONS
      and thus ruin the command-line having something like
      
          /usr/bin/c++ "-arg1 -arg2" -other -args
      
      Supersedes [!709]
      
      See merge request [!736]
      
        [!709]: gitlab.dune-project.org/NoneNone/merge_requests/709
        [!736]: gitlab.dune-project.org/core/dune-common/merge_requests/736
      13411d62
    • Stephan Hilb's avatar
      cmake: separate commandline args to list · 81fc5be3
      Stephan Hilb authored and Christoph Grüninger's avatar Christoph Grüninger committed
      Providing space-separated MPI_DUNE_COMPILE_FLAGS would previously add
      them as a single list entry to the cmake list COMPILE_OPTIONS and thus
      ruin the command-line having something like
      
          /usr/bin/c++ "-arg1 -arg2" -other -args
      81fc5be3
    • Christoph Grüninger's avatar
      [!735] Fix inconsistent chained DenseVector ctors/assignment. · 5304152a
      Christoph Grüninger authored
      Merge branch 'fix/fix-inconsistent-1d-dense-vector-conversions' into 'master'
      
      ref:core/dune-common The commit also adds a test which fails without the other
      changes in the commit.
      
      Problem is that DenseVector and FieldVector\<\..., 1\> implement catch-all
      assignment constructors and ctors. I.e., the 1d FieldVector provides CTOR
      call-signatures and the DenseVector<C> provides and assignment operator
      
      std::is_assignable<To, From\> std::is_convertible<From, To\>
      
      This poses a problem when nesting vectors and trying to assign to them from
      another DenseVector implementation.
      
      The problem is that the implementation of the CTOR and the assignment
      operation fails, but OTOH the FieldVector implementation uses
      std::is_convertible. Now std::convertible will report "yes" but the body of
      the assignment operation will fail nevertheless.
      
      The commit fixes this by restricting the call-signature to the cases where the
      implementation of the assignment and the CTOR will succeed but testing the
      assignability of DV::value_type.
      
      Supersedes [!562] as this is a rebased and squased version.
      
      See merge request [!735]
      
        [!562]: gitlab.dune-project.org/NoneNone/merge_requests/562
        [!735]: gitlab.dune-project.org/core/dune-common/merge_requests/735
      5304152a
    • Claus-Justus Heine's avatar
      Fix inconsistent chained DenseVector ctors/assignment. · bed4e242
      Claus-Justus Heine authored and Christoph Grüninger's avatar Christoph Grüninger committed
      The commit also adds a test which fails without the other changes in the
      commit.
      
      Problem is that DenseVector and FieldVector<..., 1> implement catch-all
      assignment constructors and ctors. I.e., the 1d FieldVector provides
      CTOR call-signatures and the DenseVector<C> provides and assignment
      operator
      
      std::is_assignable<To, From>
      std::is_convertible<From, To>
      
      This poses a problem when nesting vectors and trying to assign to them
      from another DenseVector implementation.
      
      The problem is that the implementation of the CTOR and the assignment
      operation fails, but OTOH the FieldVector implementation uses
      std::is_convertible. Now std::convertible will report "yes" but the body
      of the assignment operation will fail nevertheless.
      
      The commit fixes this by restricting the call-signature to the cases
      where the implementation of the assignment and the CTOR will succeed but
      testing the assignability of DV::value_type.
      bed4e242
  15. Dec 18, 2019
    • Christian Engwer's avatar
      [!721] fix ctor for Future<void> · 0ce22beb
      Christian Engwer authored
      Merge branch 'fix_future_of_void' into 'master'
      
      ref:core/dune-common There was a problem with a ctor of Future<void>. This MR
      disables the ctor if T is void. Furthermore i changed the autos in the
      mpifuturetest.cc to Futures to check for this.
      
      See merge request [!721]
      
        [!721]: gitlab.dune-project.org/core/dune-common/merge_requests/721
      0ce22beb
  16. Dec 17, 2019
Loading